Search/Filter/Delete Metadata Keywords(Named References) Enabling #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se insensitive sort..
ui/src/app/metadata/named-references/named-reference-table/named-reference-table.component.html
Outdated
Show resolved
Hide resolved
ui/src/app/metadata/named-references/named-reference-table/named-reference-table.component.html
Show resolved
Hide resolved
ui/src/app/metadata/named-references/service/named-reference.service.ts
Outdated
Show resolved
Hide resolved
ui/src/app/metadata/named-references/service/named-reference.service.ts
Outdated
Show resolved
Hide resolved
ui/src/app/metadata/named-references/service/named-reference.service.ts
Outdated
Show resolved
Hide resolved
ui/src/app/metadata/detail/metadata-list/metadata-list.component.ts
Outdated
Show resolved
Hide resolved
…search-and-filter
- Remove query parameter
manuel-delvillar
added a commit
that referenced
this pull request
Jun 28, 2023
* Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com>
8 tasks
manuel-delvillar
added a commit
that referenced
this pull request
Jul 7, 2023
* Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com>
manuel-delvillar
added a commit
that referenced
this pull request
Jul 11, 2023
* Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com>
manuel-delvillar
added a commit
that referenced
this pull request
Jul 11, 2023
* Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com>
Corpratespaz
pushed a commit
that referenced
this pull request
Jul 12, 2023
* Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com>
manuel-delvillar
added a commit
that referenced
this pull request
Jul 12, 2023
* Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com>
manuel-delvillar
added a commit
that referenced
this pull request
Jul 12, 2023
* Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com>
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 12, 2023
Search/Filter/Delete Metadata Keywords(Named References) Enabling (#426) * Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com> OSMT- 276 service classes UI (#391) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * adding providers for unit testing in abstract-data.service.spec.ts * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Remove unused code - Remove ApiGetParams. - Constructor in abstract.service now is protected. * Add alias for test directory * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one * updating openapi.yaml to match endpoint definition * Correcting Routepath and refactoring web methods * Correcting buildTableParams sort param * Updating endpoints call to match definition --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com> Adding Screen to Search/Filter Metadata (#401) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 14, 2023
Search/Filter/Delete Metadata Keywords(Named References) Enabling (#426) * Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com> OSMT- 276 service classes UI (#391) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * adding providers for unit testing in abstract-data.service.spec.ts * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Remove unused code - Remove ApiGetParams. - Constructor in abstract.service now is protected. * Add alias for test directory * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one * updating openapi.yaml to match endpoint definition * Correcting Routepath and refactoring web methods * Correcting buildTableParams sort param * Updating endpoints call to match definition --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com> Adding Screen to Search/Filter Metadata (#401) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
added a commit
that referenced
this pull request
Jul 18, 2023
* Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com>
manuel-delvillar
added a commit
that referenced
this pull request
Jul 19, 2023
* Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com>
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 19, 2023
Search/Filter/Delete Metadata Keywords(Named References) Enabling (#426) * Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com> OSMT- 276 service classes UI (#391) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * adding providers for unit testing in abstract-data.service.spec.ts * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Remove unused code - Remove ApiGetParams. - Constructor in abstract.service now is protected. * Add alias for test directory * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one * updating openapi.yaml to match endpoint definition * Correcting Routepath and refactoring web methods * Correcting buildTableParams sort param * Updating endpoints call to match definition --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com> Adding Screen to Search/Filter Metadata (#401) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 19, 2023
Search/Filter/Delete Metadata Keywords(Named References) Enabling (#426) * Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com> OSMT- 276 service classes UI (#391) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * adding providers for unit testing in abstract-data.service.spec.ts * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Remove unused code - Remove ApiGetParams. - Constructor in abstract.service now is protected. * Add alias for test directory * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one * updating openapi.yaml to match endpoint definition * Correcting Routepath and refactoring web methods * Correcting buildTableParams sort param * Updating endpoints call to match definition --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com> Adding Screen to Search/Filter Metadata (#401) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
jchavez137
added a commit
that referenced
this pull request
Jul 19, 2023
* Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com>
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 20, 2023
Search/Filter/Delete Metadata Keywords(Named References) Enabling (#426) * Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com> OSMT- 276 service classes UI (#391) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * adding providers for unit testing in abstract-data.service.spec.ts * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Remove unused code - Remove ApiGetParams. - Constructor in abstract.service now is protected. * Add alias for test directory * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one * updating openapi.yaml to match endpoint definition * Correcting Routepath and refactoring web methods * Correcting buildTableParams sort param * Updating endpoints call to match definition --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com> Adding Screen to Search/Filter Metadata (#401) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
Corpratespaz
pushed a commit
that referenced
this pull request
Jul 21, 2023
Search/Filter/Delete Metadata Keywords(Named References) Enabling (#426) * Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com> OSMT- 276 service classes UI (#391) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * adding providers for unit testing in abstract-data.service.spec.ts * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Remove unused code - Remove ApiGetParams. - Constructor in abstract.service now is protected. * Add alias for test directory * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one * updating openapi.yaml to match endpoint definition * Correcting Routepath and refactoring web methods * Correcting buildTableParams sort param * Updating endpoints call to match definition --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com> Adding Screen to Search/Filter Metadata (#401) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
manuel-delvillar
pushed a commit
that referenced
this pull request
Jul 21, 2023
Search/Filter/Delete Metadata Keywords(Named References) Enabling (#426) * Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com> OSMT- 276 service classes UI (#391) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * adding providers for unit testing in abstract-data.service.spec.ts * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Remove unused code - Remove ApiGetParams. - Constructor in abstract.service now is protected. * Add alias for test directory * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one * updating openapi.yaml to match endpoint definition * Correcting Routepath and refactoring web methods * Correcting buildTableParams sort param * Updating endpoints call to match definition --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com> Adding Screen to Search/Filter Metadata (#401) * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * Adding implementation for delete method in Abstract service * Adding new services classes for jobCodes and namedReferences * Renaming package and services name classes. Extending new abstract class from the existing one. * refactoring JobCode classes and package. Adding CRUD requests * Adding Enum for MetadataType, Optimizing Imports * updating openapi.yaml to match endpoint definition. * Correcting Routepath and refactoring web methods * Refactoring entry points in navigation bar
Corpratespaz
pushed a commit
that referenced
this pull request
Jul 25, 2023
* Refactoring Controller to accept keyword type * Renaming Keyword RoutePaths * Addind overloaded typeAheadSearch method with pageable * Working on UI, adding service endpoint calls, adding service to NR table components. * Converting delete process to be task result, adjusting labels for plural category * removing unused named reference service, fixing enum issue, fixing case insensitive sort.. * adding unit tests * Removing unused code for category screens, updating API yaml file * Removing hardcoded totalPageCount for named reference table, removing unused imports. * Reverting skillCount field back, fixing some PR comments, updating openapi.yaml * Removing unused imports. * Removing unused imports. * Refactoring deletion logic, fixing mock data. * Removing comented out line * Removing unused RoutePath * Add postman tests for job codes * Adding test coverage scripts * Adding test coverage scripts * Adding test coverage scripts * Correcting scripts. * Removing category script tests, No more needed. * Fix job code tests * Add pre request in id folder * Fix get pagination - Remove query parameter * Updating update keyword test. --------- Co-authored-by: manuel-delvillar <68391066+manuel-delvillar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.