Refactor to properly export types.#9
Merged
aaroncox merged 6 commits intowharfkit:masterfrom Sep 1, 2025
Merged
Conversation
Fix: Asset owner can be null if asset is burned. Fix: search is optional on endpoints. Fix: before and after need to be strings when POST too. Fix: Add optional images field on CollectionObject.
aaroncox
approved these changes
Sep 1, 2025
aaroncox
reviewed
Sep 1, 2025
Member
aaroncox
left a comment
aaroncox
left a comment
There was a problem hiding this comment.
Looks good! Thank you as always for being a good steward of this repository, your contributions are great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of namespaces in types.ts was causing the Assets, Market, and Tools types to not be exported correctly and be unusable for apps, e.g.
Types.Market.CollectionStat.Refactored where the types are defined and how they are exported to resolve this issue.
Also:
Fix: Asset owner can be null if asset is burned.
Fix: search is optional on endpoints.
Fix: before and after need to be strings when POST too.
Fix: Add optional images field on CollectionObject.
Two tests were also failing before I started making changes, and I had to change the Atomic API URL since the previously used one is offline.
Version bumped to 1.2.3