Pass document's settings object when processing a manifest#12353
Open
marcoscaceres wants to merge 1 commit intowhatwg:mainfrom
Open
Pass document's settings object when processing a manifest#12353marcoscaceres wants to merge 1 commit intowhatwg:mainfrom
marcoscaceres wants to merge 1 commit intowhatwg:mainfrom
Conversation
The Web App Manifest spec's "processing a manifest" algorithm now accepts an optional environment settings object (client) parameter, used to set the request client when fetching manifest image resources. This enables CSP and service worker interception for those fetches. Pass the link element's node document's relevant settings object as the client parameter when invoking "process the manifest". See: w3c/manifest#1171 See: w3c/image-resource#50
Member
Author
|
@dmurph, do you want to check this too from the Chromium side? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass document's relevant settings object when processing a manifest
The Web App Manifest spec's "processing a manifest" algorithm now accepts an optional environment settings object (
client) parameter, used to set the request client when fetching manifest image resources. This enables CSP and service worker interception for those fetches.This PR passes the link element's node document's relevant settings object as the
clientparameter when invoking "process the manifest".DownloadImageInFrame())window.fetch()through content window withmode: "cors")DenoNode.jsCorresponding HTML AAM & ARIA in HTML issues & PRs— N/AMDN issue is filed— N/A, no developer-facing changeContext
clientparameter to "processing a manifest" and defines "fetch a manifest image resource" algorithmcorsin "fetching an image resource"/links.html ( diff )