Skip to content

Pass document's settings object when processing a manifest#12353

Open
marcoscaceres wants to merge 1 commit intowhatwg:mainfrom
marcoscaceres:manifest-client-parameter
Open

Pass document's settings object when processing a manifest#12353
marcoscaceres wants to merge 1 commit intowhatwg:mainfrom
marcoscaceres:manifest-client-parameter

Conversation

@marcoscaceres
Copy link
Copy Markdown
Member

@marcoscaceres marcoscaceres commented Apr 10, 2026

Pass document's relevant settings object when processing a manifest

The Web App Manifest spec's "processing a manifest" algorithm now accepts an optional environment settings object (client) parameter, used to set the request client when fetching manifest image resources. This enables CSP and service worker interception for those fetches.

This PR passes the link element's node document's relevant settings object as the client parameter when invoking "process the manifest".


  • At least two implementers are interested (and none opposed):
    • Chromium (already fetches through document frame via DownloadImageInFrame())
    • Gecko (already fetches via window.fetch() through content window with mode: "cors")
  • Tests are written and can be reviewed and commented upon at:
    • No observable behavior change for this PR alone (wires up a parameter). Tests for the end-to-end behavior (CSP applying to manifest icon fetches) tracked in w3c/manifest#1171.
  • Implementation bugs are filed:
    • Chromium: already conformant
    • Gecko: already conformant
    • WebKit: Bug 311872
    • Deno
    • Node.js
  • Corresponding HTML AAM & ARIA in HTML issues & PRs — N/A
  • MDN issue is filed — N/A, no developer-facing change
  • The top of this comment includes a clear commit message to use.

Context


/links.html ( diff )

The Web App Manifest spec's "processing a manifest" algorithm now
accepts an optional environment settings object (client) parameter,
used to set the request client when fetching manifest image resources.
This enables CSP and service worker interception for those fetches.

Pass the link element's node document's relevant settings object as
the client parameter when invoking "process the manifest".

See: w3c/manifest#1171
See: w3c/image-resource#50
@marcoscaceres marcoscaceres requested a review from annevk April 10, 2026 06:01
@marcoscaceres
Copy link
Copy Markdown
Member Author

@dmurph, do you want to check this too from the Chromium side?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant