Rework resource selection algorithm to avoid interleaved jumps#12502
Open
nicolo-ribaudo wants to merge 1 commit into
Open
Rework resource selection algorithm to avoid interleaved jumps#12502nicolo-ribaudo wants to merge 1 commit into
nicolo-ribaudo wants to merge 1 commit into
Conversation
nicolo-ribaudo
added
topic: media
editorial
nicolo-ribaudo
force-pushed
the
rework-resource-selection
branch
from
8ef1617 to
56db1ae
Compare
nicolo-ribaudo
force-pushed
the
rework-resource-selection
branch
from
56db1ae to
5ee6502
Compare
| the node before the pointer and the new node. In other words, insertions at the pointer go | ||
| after the pointer.</p></li> | ||
|
|
||
| <li><p><span>Await a stable state</span>. The <span>synchronous section</span> consists of all |
Member
There was a problem hiding this comment.
We should probably check for NETWORK_NO_SOURCE before awaiting a stable state.
Also, these steps should get aborted on "abort the overall resource selection".
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an editorial drive-by change to make it easier to follow the resource selection algorithm when it goes into "children" mode.
Right now this algorithm has four different labeled steps, with other steps that jump to them. These jumps are interleaved with each other (3/4/5/6 -> 10, 14 -> 18, 17 -> 14, 17 -> 2, 26 -> 13), and across either separate synchronized sections or separate parallel sections.
This PR tries to convert it into something simpler to follow. There is some inherent complexity, but I feel like it makes the control flow more clear.
One editorial-but-not-as-trivial change I made is to, instead of waiting "potentially forever" for more
<source>elements to be added to the video, normally terminate the algorithm when its done iterating through the<video>children: inserting a new<source>element will then re-trigger it from the steps that keep the pointer up-to-date.These algorithms have some problems (e.g. #12500), but this PR explicitly tries to leave the problems unchanged.
Also, these algorithms call "await a stable state" while in parallel, but the first step of awaiting a stable state is to enqueue a microtask, which you can only do while not in parallel.
Wishlist for future changes that I might open a PR for:
<source>element, clarifying the moving ambiguities from Inconsistent cross-browser behavior for mutating child <source>s of a <video> #12500/media.html ( diff )