Skip to content

Add supported tokens to relList and sandbox #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add supported tokens to relList and sandbox #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3058,6 +3058,7 @@ a.setAttribute('href', 'http://example.com/'); // change the content attribute d
<li>The algorithm to <dfn data-noexport="" data-x="concept-node-clone">clone</dfn> a <code>Node</code>, and the concept of <dfn data-noexport="" data-x="concept-node-clone-ext">cloning steps</dfn> used by that algorithm</li>
<li>The concept of <dfn data-noexport="">base URL change steps</dfn> and the definition of what happens when an element is <dfn data-noexport="">affected by a base URL change</dfn></li>
<li>The concept of an element's <dfn data-noexport="" data-x="concept-id">unique identifier (ID)</dfn></li>
<li>The term <dfn data-noexport="" data-x="dom-domtokenlist-supported-tokens">supported tokens</dfn></li>

<li>The concept of a DOM <dfn data-noexport="" data-x="concept-range">range</dfn>, and the terms <dfn data-noexport="" data-x="concept-range-start">start</dfn>, <dfn data-noexport="" data-x="concept-range-end">end</dfn>, and <dfn data-noexport="" data-x="concept-range-bp">boundary point</dfn> as applied to ranges.</li>

Expand Down Expand Up @@ -12045,6 +12046,11 @@ gave me some of the songs they wrote. I love sharing my music.&lt;/p>
w-nodev>must</span> <span data-x="reflect">reflect</span> the <code
data-x="attr-link-rel">rel</code> content attribute.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That space should be removed.


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make this relList's DOMTokenList. Also, rather than "include" I would use "are" and rather than "rel values" I think the word we use is "keywords". Also, after "HTML link types" I would add "that are supported by the implementation".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will change accordingly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should include DOMTokenList here. As in "relList's DOMTokenList/DOMSettableTokenList?'s supported tokens". They are not associated with relList directly.

<p><code data-x="dom-link-rellist">relList</code>'s <code>DOMTokenList</code>'s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this not already follow from how HTML link types are defined? Ideally it should.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your view, does it follow from https://html.spec.whatwg.org/multipage/semantics.html#other-link-types ?
If so, I'll remove this line.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should pick the one relList actually returns here.

<span data-x="dom-domtokenlist-supported-tokens">supported tokens</span> are the keywords defined
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably also be further constrained to only those link types actually allowed on link elements.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this does not add the caveat I suggested about constraining this to link types that are actually supported.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not use <code>.

in <a href="#linkTypes">HTML link types</a> which are allowed on <code>link</code> elements and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already addressed by the referenced section, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/<code>link</code>/<code>link</code> elements/

supported by the user agent.</p>

</div>

<p>The <code>LinkStyle</code> interface is also implemented by this element. <ref spec=CSSOM></p>
Expand Down Expand Up @@ -27045,6 +27051,11 @@ href="?audio">audio&lt;/a> test instead.)&lt;/p></pre>
<p>The IDL attributes <dfn><code data-x="dom-iframe-src">src</code></dfn>, <dfn><code data-x="dom-iframe-srcdoc">srcdoc</code></dfn>, <dfn><code data-x="dom-iframe-name">name</code></dfn>, <dfn><code data-x="dom-iframe-sandbox">sandbox</code></dfn>, and <dfn><code data-x="dom-iframe-seamless">seamless</code></dfn> must <span>reflect</span> the respective
content attributes of the same name.</p>

<p>The <span data-x="dom-domtokenlist-supported-tokens">supported tokens</span> for
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/include/are/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

<code data-x="dom-iframe-sandbox">sandbox</code>'s <code>DOMSettableTokenList</code> are the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

</p>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be constrained to the values actually implemented.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also have something like "sandbox's DOMSettableTokenList".

allowed values defined in the <code data-x="attr-iframe-sandbox">sandbox</code> attribute and
supported by the user agent.</p>

<p>The <dfn><code data-x="dom-iframe-allowFullscreen">allowFullscreen</code></dfn> IDL attribute
must <span>reflect</span> the <code data-x="attr-iframe-allowfullscreen">allowfullscreen</code>
content attribute.</p>
Expand Down