Add supported tokens to relList and sandbox #340
Conversation
source
Outdated
There was a problem hiding this comment.
I would make this relList's DOMTokenList. Also, rather than "include" I would use "are" and rather than "rel values" I think the word we use is "keywords". Also, after "HTML link types" I would add "that are supported by the implementation".
There was a problem hiding this comment.
OK, will change accordingly.
|
LGTM but will let @annevk take another look. (The "other specifications" thing looks unresolved.) |
|
@annevk let me know if you approve or the "other specifications" part needs to be removed. Afterwards, I'll rebase and squash. |
source
Outdated
There was a problem hiding this comment.
I think you should include DOMTokenList here. As in "relList's DOMTokenList/DOMSettableTokenList?'s supported tokens". They are not associated with relList directly.
|
@annevk I believe I addressed everything you raised, but please verify :) |
source
Outdated
There was a problem hiding this comment.
You should pick the one relList actually returns here.
|
Apart from that space, it seems the wrapping is not really correct. If you want I can address both. (Or whoever merges this.) |
Add the following: * Reference to DOMTokenList's supported tokens in the DOM spec. * Supported tokens to HTMLLinkElement's relList. * Supported tokens to HTMLIFrameElement's sandbox.
yoavweiss
force-pushed
the
supported_tokens
branch
from
902afdf to
2fb8c50
Compare
|
Fixed wrapping and space as well as squashed |
|
Thank you! I tweaked it some more. :-) |
3 participants
This is the HTML side of whatwg/dom#103
@annevk/@zcorpan - can you take a look?