Fixes to stopping document loading #6720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Makes the discussion of user agent interface invoke "stop document loading", not "abort a document", since the browser stop button also cancels ongoing navigations. * Remove the "should" suggestion to fire an abort event. Closes #3525. Since this was the only case where abort was fired, this removes the event definition and event handler content attribute definition, effectively making use of the onabort="" content attribute nonconforming. (But, we keep the IDL definition in GlobalEventHandlers and the associated mapping.) * Tweaks the active document check in "stop document loading" to be more correct.
domenic
added
removal/deprecation
annevk
reviewed
May 26, 2021
|
|
||
| <!-- I'd love to make this more precise, anyone have any suggestions on what it should say? --> | ||
| <p>User agents may allow users to explicitly invoke the <span>stop document loading</span> for a | ||
| <code>Document</code>.</p> |
Member
There was a problem hiding this comment.
Including nested documents? I suppose browsers only offer this for the top-level?
Member
Author
There was a problem hiding this comment.
You can do it using the context menu in Firefox, although apparently not Chrome: https://boom-bath.glitch.me/slow-subframe-outer.html
(in Chrome the context menu continues to say "Reload" even while a document is loading.)
annevk
approved these changes
May 26, 2021
Member
Author
|
I double-checked by source inspection that all three engines still have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the discussion of user agent interface invoke "stop document loading", not "abort a document", since the browser stop button also cancels ongoing navigations.
Remove the "should" suggestion to fire an abort event. Closes "abort" Event Isn't Fired When Aborting Document Load #3525. Since this was the only case where abort was fired, this removes the event definition and event handler content attribute definition, effectively making use of the onabort="" content attribute nonconforming. (But, we keep the IDL definition in GlobalEventHandlers and the associated mapping.)
Tweaks the active document check in "stop document loading" to be more correct.
/cc @jgraham since he's been looking at the specs for high-level "UI actions" recently.
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/dom.html ( diff )
/indices.html ( diff )
/webappapis.html ( diff )