Replace // lines with # in whatwg-headers.conf#155
Conversation
I don’t know why this didn’t cause any problems earlier, but since lines starting with // aren’t valid comments in nginx config files, the lines we had starting with // were causing nginx to fail to parse the config file, and to fail to start. So, this replaces those // with #.
999e751 to
9df09ba
Compare
|
Same problem in |
Interesting. For some reason those instances don’t cause the server syntax checker to throw, while the ones in the |
|
It seems that per https://nginx.org/en/docs/beginners_guide.html#conf_structure those should be |
foolip
left a comment
There was a problem hiding this comment.
@sideshowbarker can you get this change deployed?
Yeah, I had deployed it already from this PR branch. But after merging this, I doublechecked by re-deploying from the main branch, with no failures. So I think for now at least, as far as the instances of the |
I don’t know why this didn’t cause any problems earlier, but since lines starting with
//aren’t valid comments in nginx confing files, the lines we had starting with//were causing nginx to fail to parse the config file, and to fail to start.So, this replaces those
//with#.