[variant-json] made mutable with vendoring/inlining#43
Merged
mgorny merged 12 commits intopep-wheel-variants-acceptancefrom Feb 27, 2026
Merged
[variant-json] made mutable with vendoring/inlining#43mgorny merged 12 commits intopep-wheel-variants-acceptancefrom
mgorny merged 12 commits intopep-wheel-variants-acceptancefrom
Conversation
DEKHTIARJonathan
force-pushed
the
variant-json-inlining
branch
from
0767c22 to
2cfb0b5
Compare
mgorny
reviewed
Feb 26, 2026
mgorny
reviewed
Feb 26, 2026
mgorny
reviewed
Feb 26, 2026
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
Signed-off-by: Michał Górny <mgorny@quansight.com>
mgorny
approved these changes
Feb 26, 2026
mgorny
left a comment
mgorny
left a comment
There was a problem hiding this comment.
I've reflowed, reworded, fixed formatting and added an example.
rgommers
approved these changes
Feb 26, 2026
| version = "2.3.4" | ||
| index = "https://pypi.anaconda.org/mgorny/simple" | ||
| wheels = [ | ||
| { url = "https://pypi.anaconda.org/mgorny/simple/numpy/2.3.4/numpy-2.3.4-cp314-cp314-linux_x86_64-openblas.whl", hashes = {} }, |
There was a problem hiding this comment.
Not sure if this uses pypi.anaconda.org on purpose or not. It might raise some eyebrows, so a non-existing pypi.org link might possibly be better. I'm not certain though.
There was a problem hiding this comment.
It's an exact lock file generated by uv for the test packages I've built (except for variant metadata format that changes here) :-).
Signed-off-by: Michał Górny <mgorny@quansight.com>
konstin
approved these changes
Feb 27, 2026
peps/pep-0825.rst
Outdated
Comment on lines
763
to
765
| Since the clients may cache the file at any point, it is recommended not | ||
| to publish it until it contains the metadata for all variants. If the | ||
| index is responsible for generating the file, it should use some |
There was a problem hiding this comment.
I wouldn't say it like that and phrase it differently, you should upload all wheels roughly at the same time anyway.
Signed-off-by: Michał Górny <mgorny@quansight.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://wheelnext-peps--43.org.readthedocs.build/