Skip to content

Fix scope resolution for plugins by using wirebox to initialize test … #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zainforbjs merged 1 commit into from
Sep 9, 2025
Merged

Fix scope resolution for plugins by using wirebox to initialize test … #1725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/src/wheels/Plugins.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,8 @@ component output="false" extends="wheels.Global"{
$wheels.className = "controller";
} else if (findNoCase("models", $wheels.metaData.fullname)){
$wheels.className = "model";
} else if (findNoCase("tests", $wheels.metaData.fullname)){
$wheels.className = "test";
} else {
$wheels.className = Reverse(SpanExcluding(Reverse($wheels.metaData.name), "."));
}
Expand Down
2 changes: 1 addition & 1 deletion core/src/wheels/Test.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ component output="false" displayName="Test" extends="wheels.Global"{
local.i = 0;
for (local.row in local.packages) {
local.i++;
local.instance = CreateObject("component", local.row.package);
local.instance = application.wirebox.getInstance(name = "#local.row.package#");
// is there a better way to check for existence of a function?
// if the beforeall method is present, run it once only per request
if (StructKeyExists(local.instance, "beforeAll") && local.i eq 1) {
Expand Down