Fix CockroachDB primary key: use unique_rowid() instead of SERIAL#1986
Merged
Fix CockroachDB primary key: use unique_rowid() instead of SERIAL#1986
Conversation
…f SERIAL CockroachDB does not support PostgreSQL's SERIAL type. Override addPrimaryKeyOptions in CockroachDBMigrator to use INT DEFAULT unique_rowid() for auto-increment primary keys. Fixes #1970 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Wheels Test Matrix
Results for commit e44210c. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addPrimaryKeyOptions()which replacesINTEGERwithSERIAL-- a type CockroachDB does not supportCockroachDBMigrator.cfcthat usesINT DEFAULT unique_rowid()instead, which is CockroachDB's idiomatic auto-generated primary key patternFixes #1970
Test plan
CREATE TABLEstatements useINT DEFAULT unique_rowid() PRIMARY KEYinstead ofSERIAL PRIMARY KEYSERIAL)🤖 Generated with Claude Code