feat: CockroachDB RETURNING clause identity select and adapter tests#1993
Merged
Conversation
…apter tests Replace the pg_get_serial_sequence/currval fallback with a RETURNING clause approach that works reliably with CockroachDB's unique_rowid() default keys. Add unit and integration test specs, fix migrator regex to match INTEGER, and add ?sslmode=disable to CockroachDB test datasources. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Wheels Test Matrix
Results for commit 628c348. |
Contributor
Wheels Test Results 32 files ± 0 3 360 suites +390 14m 48s ⏱️ + 2m 36s For more details on these failures and errors, see this check. Results for commit be109ef. ± Comparison against base commit 4136bc2. ♻️ This comment has been updated with latest results. |
The commitlint job uses `npm ci` which requires a lockfile, but package-lock.json was gitignored. Remove it from .gitignore and commit the generated lockfile. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
dependencies
Collaborator
Author
|
CockroachDB soft-fail test failures (84 fail + 123 error) are pre-existing — they affect the core test suite running against CockroachDB (UPDATE SQL generation, boolean coercion, populate.cfm table creation). Full CockroachDB compatibility will be addressed in a separate PR. |
This was referenced May 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pg_get_serial_sequence()/currval()fallback in CockroachDBModel with aRETURNINGclause approach via$querySetup()— works reliably with CockroachDB'sunique_rowid()default keysCockroachDBUnitSpec.cfcandCockroachDBIntegrationSpec.cfctest specs (not previously on develop)addPrimaryKeyOptionsregex to match bothINTandINTEGER?sslmode=disableto CockroachDB test datasources in all 8 CFConfig.json filesTest plan
🤖 Generated with Claude Code