fix: change RateLimiter trustProxy default to false#2024
Merged
Conversation
With trustProxy=true (previous default), any client could spoof their IP via X-Forwarded-For header to get a fresh rate limit bucket per request, completely bypassing rate limiting. Default to false so apps are secure out of the box; users behind a trusted reverse proxy can opt in. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trustProxydefault fromtruetofalseinRateLimiter.cfcto prevent IP spoofing viaX-Forwarded-ForRateLimiterSpec.cfcwith 5 tests covering default behavior, explicit false, explicit true, spoofing prevention, and remoteAddr fallbackSecurity Impact
With
trustProxy=true(previous default), any client could setX-Forwarded-For: <random-ip>to get a fresh rate limit bucket on every request, completely defeating rate limiting. This is a breaking change for apps that rely on the previous default and are behind a reverse proxy -- they will need to explicitly settrustProxy=true.Test plan
RateLimiterSpectests cover: default=false, explicit false ignores XFF, explicit true uses XFF, spoofing blocked with default, remoteAddr priority🤖 Generated with Claude Code