fix: escape single quotes in $quoteValue() to prevent SQL injection#2033
Merged
fix: escape single quotes in $quoteValue() to prevent SQL injection#2033
Conversation
$quoteValue() wrapped strings in single quotes without escaping embedded quotes, allowing values like "test' OR '1'='1" to break out of the quoted context. Now escapes ' → '' before quoting. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
SQLite is the primary test database. Avoids coupling tests to H2 which may not be available in all environments. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$quoteValue()(vendor/wheels/databaseAdapters/Base.cfc)test' OR '1'='1to break out of the quoted contextReplace(arguments.str, "'", "''", "all")before wrapping in quotes — standard SQL single-quote escapingQuoteValueSpec.cfcwith 9 test cases covering injection payloads, edge cases, and numeric passthroughTest plan
$quoteValue("test' OR '1'='1")returns'test'' OR ''1''=''1'(escaped)🤖 Generated with Claude Code