fix(model): validate calculated property SQL at config time#2067
Merged
Conversation
Adds $validateCalculatedPropertySql() that rejects dangerous SQL patterns (UNION, EXEC, xp_, SLEEP, BENCHMARK, LOAD_FILE, INTO OUTFILE/DUMPFILE) when property(sql="...") is called during model config. Defense-in-depth against supply-chain or accidental injection of user input into calculated property SQL expressions.
- Change semicolon pattern from ;\s to bare ; (no legitimate semicolons
in calculated property expressions)
- Change EXEC\s to \bEXEC(UTE)?\b to catch both EXEC and EXECUTE as
whole words, including EXECUTE('dynamic sql') without spaces
- Add \b word boundaries to UNION to prevent false positives
- Add tests for bare semicolons and EXECUTE keyword
This was referenced May 12, 2026
Merged
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$validateCalculatedPropertySql()that rejects dangerous SQL patterns (UNION, EXEC, xp_, SLEEP, BENCHMARK, LOAD_FILE, INTO OUTFILE/DUMPFILE) whenproperty(sql="...")is called during model configTest plan
vendor/wheels/tests/specs/security/CalculatedPropertySqlSpec.cfccovers rejection of 9 dangerous patterns and acceptance of 5 legitimate SQL expressionsbash tools/test-local.sh model— no regressionsbash tools/test-local.sh security— new tests pass