feat(model): add bulk insert and upsert operations#2101
Merged
Conversation
Adds insertAll() and upsertAll() class-level methods to the ORM with database-specific UPSERT syntax for all 7 adapters (PostgreSQL, MySQL, SQL Server, SQLite, H2, CockroachDB, Oracle). Includes BulkItem test model and comprehensive BDD spec. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove dead quoteFunc parameter from all $upsertSQL adapter signatures. Register insertAll/upsertAll in application function defaults for proper parameterize handling. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Oracle: Replace string-interpolated SELECT FROM dual values with parameterized $buildBulkParam (fixes SQL injection vulnerability). Restructure to use single MERGE with UNION ALL of SELECT FROM dual so multi-row batches execute as one statement instead of being split with semicolons (which JDBC rejects). H2: Combine multi-row batches into single MERGE INTO ... VALUES (...) statement instead of multiple statements separated by semicolons. Also quote identifiers consistently with other adapters. Test: Verify createdAt/updatedAt are empty when timestamps=false. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bpamiri
force-pushed
the
peter/bulk-operations
branch
from
ad691f3 to
de093eb
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
insertAll()andupsertAll()class-level methods to the Wheels ORM via newmodel/bulk.cfcmixinON CONFLICT ... DO UPDATEON DUPLICATE KEY UPDATEMERGEMERGE INTO ... KEYcreatedAt/updatedAt)BulkItemtest model and comprehensive BDD specCloses the bulk operations gap (
insert_all/upsert_all) identified indocs/wheels-vs-frameworks.md.Test plan
bash tools/test-local.sh— all existing tests passvendor/wheels/tests/specs/model/bulkOperationsSpec.cfcpass🤖 Generated with Claude Code