fix(test): resolve 20 browser-spec errors with root-cause fixes

[bpamiri]

Summary

Resolves the 20 browser-test errors that surface when running bash tools/test-local.sh on Lucee 7 + SQLite. Prior state: 3063 pass / 0 fail / 20 error. New state: 3067 pass / 0 fail / 0 error. All 119 browser specs (BrowserDialog/Integration/Launcher/Login/Route/TestLifecycle) are now green.

Three distinct root causes, each fixed directly — no skip/gate workarounds.

1. Lucee 7 rejects struct-based createDynamicProxy targets (8 dialog errors)

BrowserClient.$requireDialogSupport() and $registerDialogListener() passed an inline struct with an accept closure as the proxy target. Lucee 7 tightened the first-argument type to require a Component — structs now fail with "Can't cast Complex Object Type Struct to String" as Lucee tries the CFC-path-string overload first.

Fix: new wheels.wheelstest.DialogConsumer CFC that encapsulates the Consumer<Dialog> handler logic, parameterized with the caller's state and action structs. Both the probe and the real handler now pass a CFC instance. Probe also corrected from java.lang.Runnable (method run()) to java.util.function.Consumer (method accept(T)) to match the interface actually used in dialog handling.

2. Named fixture routes not visible during core tests (5 route errors)

Two sub-problems:

a) vendor/wheels/tests/routes.cfm (the core test runner's route file) did not declare the _browser/* fixture routes — only the app's config/routes.cfm did.

b) Other specs in the core suite (mapperSpec, security/PaginationXssSpec, view/linksSpec, view/formsSpec) legitimately call $clearRoutes() to test route-registration behavior and do not restore afterwards. Bundles run alphabetically, so those specs wipe the route table before browser specs execute.

Fix A: register _browser/* fixture routes in vendor/wheels/tests/routes.cfm.
Fix B: BrowserTest.beforeAll() re-includes the test routes file and calls $setNamedRoutePositions(), making browser specs self-contained regardless of earlier specs' route-wiping.

3. Fixture controllers + views only existed in the app tree (7 login errors)

The core test runner swaps controllerPath to /wheels/tests/_assets/controllers, so the app-tree BrowserTestHome.cfc, BrowserTestLogin.cfc, BrowserTestSessions.cfc and their views are invisible during core tests. Playwright requests returned empty responses, failing assertions like "Expected page to contain 'alice@example.com'".

Fix: copied the three fixture controllers + six view templates into vendor/wheels/tests/_assets/. The loginAs env-gate in the app copy references application.$wheels which is cleared post-init — the vendor copy omits the gate since these routes are only loaded by the core test runner.

Also

• tools/test-local.sh exports WHEELS_BROWSER_TEST_BASE_URL=http://localhost:${PORT} so Playwright hits the running server instead of the default localhost:8080. CI's own export is preserved via the ${VAR:-default} pattern.

Test plan

• PORT=9090 bash tools/test-local.sh on Lucee 7 + SQLite: 3067 pass / 0 fail / 0 error (was 3063 pass / 0 fail / 20 error).
• Verified all 6 browser bundles green: BrowserDialog (9/9), BrowserIntegration (63/63), BrowserLauncher (26/26), BrowserLogin (7/7), BrowserRoute (5/5), BrowserTestLifecycle (9/9).
• Confirmed non-browser specs unaffected by route re-registration in BrowserTest.beforeAll — full suite passes cleanly.
• Confirmed DialogConsumer CFC works when multiple dialog assertions run sequentially (probe caches the $dialogSupported=true result on first call).

Why not just skip?

Skipping via WHEELS_CI=true masked three real bugs:

• The Lucee 7 struct-proxy incompatibility would have continued to break any code path that tried to proxy a CFML struct to a Java interface.
• The fixture-route gap would have left a latent coupling between app routes and core tests.
• The test-asset controllers being missing was a long-standing drift from when the app fixtures were introduced.

Each root-cause fix unlocks the actual capability rather than hiding the symptom.

🤖 Generated with Claude Code