feat(cli): gate wheels doctor mixin-collision detail behind --verbose#2287
Merged
feat(cli): gate wheels doctor mixin-collision detail behind --verbose#2287
Conversation
Default output now shows a single-line count summary; full per-collision detail is enumerated only under `wheels doctor --verbose`. Structured collision entries live on `results.mixinCollisions` so the service stays presentation-neutral. Closes #2261
`$extract()` threw on any non-empty stderr, which tripped on GNU tar's
informational warnings ("Ignoring unknown extended header keyword
'LIBARCHIVE.xattr.com.apple.provenance'") when extracting macOS-authored
tarballs on Linux. Extraction still succeeded — exit code 0 — so the
stderr check was spurious.
Switch to cfexecute's `result=` arg and throw only when `exitCode != 0`,
preserving stderr in extendedInfo for diagnostics.
Fixes 4 CI errors in InstallerSpec / PackagesMainCliSpec that were
previously masked by TestBox's negative totalError accounting.
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wheels doctornow shows a single"N mixin collision(s) detected — run with --verbose for details"summary by default; full per-collision enumeration is gated behind--verbose/-v.Doctor.runChecks()exposes a newresults.mixinCollisionsarray of structured entries (target, method, firstName, firstSource, secondName, secondSource) so the service stays presentation-neutral.--verboseis set.Closes #2261. Follow-up to #2245.
Test plan
bash tools/test-cli-local.sh→ 432 pass, 0 fail, 0 errorDoctorSpec.checkMixinCollisionsspecs: summary-only in default warnings, structured detail inresults.mixinCollisions, participants asserted order-agnostically (directoryList ordering is FS-dependent)mixinCollisions