fix: update blob/master to blob/main in base template manifest#2554
fix: update blob/master to blob/main in base template manifest#2554
Conversation
The wheels-base-template package's license URL on ForgeBox pointed at the obsolete master branch, producing a soft 404. The default branch has been main since the v3.0 rebrand. PR #2546 fixed the same issue in the sister core template; this catches the base template that was flagged as out of scope for that PR.
There was a problem hiding this comment.
Wheels Bot — Reviewer A
TL;DR: This is a clean, minimal one-line fix that updates the stale blob/master license URL in tools/build/base/box.json to blob/main, matching the default branch name since the v3.0 rebrand. The change is correct and the commit message is well-formed. Approving with one informational note about sibling files that have the same stale reference.
Correctness
The fix does exactly what the PR claims. The license URL in tools/build/base/box.json at line 47 now reads:
"URL":"https://github.com/wheels-dev/wheels/blob/main/LICENSE"This mirrors the fix applied to tools/build/core/box.json in PR #2546 and resolves the soft-404 on the ForgeBox package page. No other blob/master references remain in either of the two tools/build/ manifests.
Nit — sibling examples/ manifests have the same stale reference
grep -rn "blob/master" examples/ turns up two more files that reference wheels-dev/wheels/blob/master/LICENSE:
examples/tweet/box.jsonline 48examples/starter-app/box.jsonline 42
Neither is published to ForgeBox as actively as the base/core templates, but they will eventually produce the same soft-404 if they ever are. A follow-up PR updating them would be a tidy close-out. Not blocking — this PR's scope is correct as stated.
Commits
Single commit 1a20b917: fix: update blob/master to blob/main in base template manifest
- Type
fix— valid. - No scope — acceptable; no allowed scope maps cleanly to a ForgeBox manifest under
tools/build/. - Subject is 53 characters, sentence-case, not ALL-CAPS.
- Body explains the why (soft-404, v3.0 rebrand, companion to #2546) clearly.
All checks pass.
Wheels Bot — Reviewer B (round 1)A's review is substantively correct. The fix is a clean, verifiable one-line change, the commit is well-formed, and the approve verdict is appropriate. One gap: A's nit enumeration of stale SycophancyNone detected. A's approval is supported by explicit verification of the changed line and a commit message breakdown. No evidence-free LGTM. False positivesNone detected. I re-ran the greps A cited:
Missed issuesA's nit enumeration is incomplete. The full
The CLI template files ( Verdict alignmentA's approve is consistent with the findings. This PR's scope is one file, the fix is correct, and the remaining stale references belong in a follow-up. ConvergenceAligned. A's verdict and mine are both approve. The missed nit items are informational and do not warrant changes to this PR. Emitting converged-approve. |
Summary
wheels-base-templateForgeBox package'slicense[].URLintools/build/base/box.jsonstill pointed atblob/master/LICENSE. The repo's default branch has beenmainsince the v3.0 rebrand, so the link soft-404s on the ForgeBox package page.tools/build/core/box.json. Reviewer A flagged the base file as a pre-existing issue out of scope for that PR — this catches it.changelogfield exists in this manifest; the LICENSE URL is the onlyblob/master/reference.Test plan
grep -n master tools/build/base/box.jsonreturns nothing after the changewheels-base-templaterenders the license link as a workinghttps://github.com/wheels-dev/wheels/blob/main/LICENSE