chore(scoop): remove stale draft manifests; bucket repo is authoritative

[bpamiri]

Summary

• Delete tools/distribution-drafts/scoop/ (5 files, ~1050 lines): the build-manifests.py generator, validate.py static checker, and the two .json drafts plus their README.
• Trim the two scoop rows from the parent tools/distribution-drafts/README.md table and replace the "keep-or-remove for drift signal" paragraph with a brief note explaining why scoop is no longer drafted here.

Rationale captured in the commit message; short version: the live wheels-dev/scoop-wheels bucket has had its own self-hosted autoupdate workflow since scoop-wheels@3f22250 (May 18) and diverged from this draft on every meaningful axis (inline JDK, real hashes, autoupdate strategy, and now the wrapper fix from scoop-wheels#6). The parent README originally framed keeping the drafts as a "useful diff signal" — empirically that signal was ignored for two snapshot releases, and the stale drafts only confused the recent debug session that surfaced as wheels#2765.

Test plan

• No CI consumes these files (grep -r distribution-drafts/scoop only matches build-manifests.py itself and the parent README). release.yml only references linux-packages/, apt-repo/, yum-repo/ from this tree.
• Bucket repo is untouched. wheels-dev/scoop-wheels#6 (the wrapper fix) is already merged and verified end-to-end on a clean reinstall (see comment thread on wheels#2765).
• tools/distribution-drafts/README.md still scans cleanly — only the scoop entries removed.

Closes #2765

[wheels-bot]

Wheels Bot — Reviewer A

TL;DR: PR #2767 removes the stale tools/distribution-drafts/scoop/ subdirectory (5 files, ~1050 lines) and trims the matching rows and rationale paragraph from the parent README. The change is correct, the rationale is solid, and nothing in CI or release.yml references the deleted paths. Approving.

Correctness

The diff does exactly what the PR description says. A quick cross-check confirms no CI workflow touches the deleted paths:

• grep -r "distribution-drafts/scoop" .github/ — no matches. release.yml only references linux-packages/, apt-repo/, yum-repo/ from this tree.
• The parent README update is self-consistent: the two scoop table rows are removed and the new section accurately explains why the bucket repo is now authoritative.

Docs

tools/distribution-drafts/README.md is updated in the same commit and the prose is clear. No user-facing framework behaviour changed, so no .ai/wheels/ or web/sites/guides/ pages need updating.

Commits

Single commit: chore(scoop): remove stale draft manifests; bucket repo is authoritative

• Type chore is valid per commitlint.config.js. Scope scoop is a fine optional qualifier.
• Subject is 55 chars, sentence-case, no ALL-CAPS. Body fully explains the divergence timeline and closes the originating issue.
• DCO Signed-off-by: Peter Amiri <peter@alurium.com> is present.

One heads-up

mergeStateStatus is DIRTY, meaning the chore/remove-stale-scoop-drafts branch has conflicts with the current develop HEAD (likely because some recent hotfix commits landed on main out-of-order). A git rebase origin/develop before merge should resolve this cleanly — the deleted files have not been touched on develop, so the rebase should be trivial.

[bpamiri]

Resolved merge conflict with #2766 (merged into develop while this PR was open).

The conflict was strategic, not just textual — #2766 took the "keep the drafts and patch them to match the wrapper fix" approach to the same root cause (#2765). Per discussion, the project's preferred end state is a clean slate where the live wheels-dev/scoop-wheels bucket is the unambiguous source of truth and not mirrored here. To get there from the post-#2766 develop state, this PR now also reverses three things #2766 added that are orphaned by the drafts deletion:

1. vendor/wheels/tests/specs/cli/ScoopWrapperSpec.cfc — pins assertions to literal paths under tools/distribution-drafts/scoop/; first assertion is expect(fileExists(t.path)).toBeTrue("Missing file..."). Deleted along with the drafts it validated.
2. Four .mdx install docs — fix(cli): scoop wheels.cmd invokes java.exe directly to dodge cmd.exe bat-jar pre-parse #2766 reworded them to require scoop bucket add java and described JAVA_HOME as auto-resolved from a depends: java/openjdk21 declaration. The live bucket inlines OpenJDK 21 (scoop-wheels@3f22250) and uses neither pattern, so the rewording was factually wrong for the bucket users actually install. Reverted to the pre-fix(cli): scoop wheels.cmd invokes java.exe directly to dodge cmd.exe bat-jar pre-parse #2766 inline-JDK prose, which matches the live bucket.
3. CHANGELOG.md line 40 — rewritten to describe the actual landed state: wrapper fix lives in wheels-dev/scoop-wheels#6 (already merged + verified end-to-end on a clean reinstall), draft generator removed here, parent README updated. Replaces fix(cli): scoop wheels.cmd invokes java.exe directly to dodge cmd.exe bat-jar pre-parse #2766's description of a fix that no longer exists in this tree.

Net diff vs develop: 12 files, +13 / −1296.

Closes #2765

[wheels-bot]

Wheels Bot — Reviewer A

TL;DR: PR #2767 started as a five-file deletion of the stale Scoop draft manifests, then gained a develop merge that pulled in four docs updates, a CHANGELOG consolidation, and the deletion of ScoopWrapperSpec.cfc. The core deletion is correct and the docs changes are internally consistent; there are no correctness, cross-engine, or security findings. Commenting with two minor observations before merge.

Correctness

The deletions are clean. A cross-check confirms no CI workflow references the removed paths; release.yml only touches linux-packages/, apt-repo/, and yum-repo/ from this tree.

The develop merge (head commit d6b456b5) resolved three conflicts in the files being deleted — the conflict markers are gone, the files are absent, and the merge commit is consistent with the PR intent.

The docs updates across v4-0-0 and v4-0-1-snapshot are symmetric and consistent with the CHANGELOG entry: the canonical bucket now bundles OpenJDK 21 at %~dp0jdk-21.0.2 (described as inline rather than via depends: java/openjdk21), so removing the scoop bucket add java prerequisite step is correct.

Tests

vendor/wheels/tests/specs/cli/ScoopWrapperSpec.cfc is deleted. The spec was correct to remove — every it block opens with:

expect(fileExists(t.path)).toBeTrue("Missing file: " & t.path);

Keeping it with the draft JSONs gone would fail the entire cli/ suite bundle immediately. Deletion is the only option.

Worth noting: this removes the only in-repo regression guard against the two bugs from issue 2765 (the call lucli.bat pre-parser crash and the dead JAVA_HOME=%~dp0share\jdk assignment). The canonical bucket is now the sole source of truth for wrapper correctness; there is no equivalent regression spec in the bucket repo. This is an accepted trade-off, but future bucket maintainers lose that safety net silently.

Docs

The four installation.mdx / installing.mdx changes correctly drop the scoop bucket add java step and update the prose from "installs OpenJDK 21 as a Scoop dependency" to "bundles OpenJDK 21 inline." Both v4-0-0 and v4-0-1-snapshot copies are updated in the same diff, which is correct.

Commits

• 7c35239d — chore(scoop): remove stale draft manifests; bucket repo is authoritative — valid type, optional scope, 55-char subject, exemplary body (divergence timeline, no-CI-consumers confirmation, bucket rationale). DCO Signed-off-by: Peter Amiri <peter@alurium.com> present.
• d6b456b5 — merge commit, standard subject, DCO sign-off present.

One pre-merge housekeeping note

The PR description was written against the original five-file deletion commit and was not updated after the develop merge. The actual diff now includes ScoopWrapperSpec.cfc, four docs files, and a CHANGELOG edit that are not mentioned in the description. This is cosmetic — the diff and commits tell the full story — but updating the PR body to reflect the full scope before merge would help anyone reading the PR summary after the fact.

[wheels-bot]

Wheels Bot — Reviewer B (round 1)

A's review is substantiated and catches the important angles (CI non-consumption, test deletion rationale, docs symmetry). One factual inconsistency in the CHANGELOG was missed; everything else checks out.

Sycophancy

None detected. A chose COMMENTED over approve, cited specific files and line content for every claim, and explicitly flagged the loss of the regression guard rather than glossing over it.

False positives

None detected.

• A's claim that ScoopWrapperSpec.cfc deletion is necessary is accurate: the spec opens every it block with a fileExists assertion against paths under tools/distribution-drafts/scoop/, so the deleted draft JSONs would immediately fail the entire cli/ bundle.
• A's claim that the four docs files drop the scoop bucket add java step is accurate: the diff confirms -scoop bucket add java removals in all four .mdx files.
• A's CI non-consumption check is accurate: release.yml only references linux-packages/, apt-repo/, and yum-repo/ from this tree.

Missed issues

CHANGELOG.md — self-contradictory scoop bucket add java entry

The diff only rewrites line 40 (the scoop wrapper bug description). It leaves untouched the bullet added by #2761 (context line in the diff):

Docs: Windows install steps in start-here/installing.mdx and command-line-tools/installation.mdx now call out scoop bucket add java as a prerequisite. Scoop's depends: declaration does not auto-add the dependency bucket on the user's behalf, so users hit Couldn't find manifest for 'openjdk21' from 'java' bucket before they could proceed (#2761)

This PR removes scoop bucket add java from those exact four files. After merge the release notes will simultaneously say "we added scoop bucket add java as a prerequisite" and "the wrapper bundles OpenJDK 21 inline." These two statements are contradictory — the first implies a depends: java/openjdk21 layout; the second confirms inline JDK with no such dependency. A user following the first instruction against the live bucket would hit the same Couldn't find manifest for 'openjdk21' error the line was written to prevent.

Fix: remove or replace the #2761 docs bullet in CHANGELOG.md. The net docs state for this release does not include scoop bucket add java as a prerequisite.

Verdict alignment

A's COMMENTED verdict is appropriate for the two observations A did flag, but it does not account for the CHANGELOG contradiction above, which is a factual error in user-facing release notes and warrants a change before merge.

Convergence

Not aligned. A needs to address the stale #2761 CHANGELOG bullet that contradicts the docs revert in this PR. Once that line is removed or amended, the PR is clean and can merge. No code, no cross-engine concerns, no test coverage gaps beyond what A already noted.

[wheels-bot]

Wheels Bot — Reviewer A response (round 1)

B caught a real issue I missed: the #2761 CHANGELOG bullet is left untouched by this PR, and after merge it directly contradicts what the docs now say. I concede that finding and update my verdict to request-changes. My other observations (CI non-consumption, test deletion rationale, docs symmetry) were confirmed accurate by B and stand unchanged.

Conceded points

• CHANGELOG.md #2761 bullet contradiction. The diff removes scoop bucket add java from the four .mdx install files (confirmed: all four - scoop bucket add java removals are visible in the diff). The untouched context line in the diff reads: "Docs: Windows install steps in start-here/installing.mdx and command-line-tools/installation.mdx now call out scoop bucket add java as a prerequisite." After merge, the release notes simultaneously say that step was added and the actual docs omit it. A reader following CHANGELOG guidance against the live bucket would hit the same Couldn't find manifest for 'openjdk21' error that bullet was written to prevent. The fix is to remove or replace that bullet — the net docs state for this release does not include scoop bucket add java.

Defended points

• CI non-consumption. release.yml and related workflows reference only linux-packages/, apt-repo/, yum-repo/ from this tree — no distribution-drafts/scoop/ reference. The deleted paths are not consumed by any CI step. B confirmed this; no change to position.
• ScoopWrapperSpec.cfc deletion. Every it block opens with expect(fileExists(t.path)).toBeTrue(...) against paths under tools/distribution-drafts/scoop/. Keeping the spec with those files gone would crash the entire cli/ bundle on first compile. Deletion is the only viable option; the trade-off (loss of regression guard) is accepted and noted. B confirmed this; no change to position.
• Docs symmetry. Both v4-0-0 and v4-0-1-snapshot copies of installing.mdx / installation.mdx are updated in the same diff. The inline-JDK description is consistent across all four changed files. B confirmed this; no change to position.

Updated verdict

Request changes: the #2761 CHANGELOG bullet must be removed or amended (the net docs state for this release does not include scoop bucket add java) before the PR is clean to merge. All other findings are resolved.