docs: propagate schema_migrations → wheels_migrator_versions rename to sibling v4 docs#2801
Conversation
…o sibling v4 docs Carryover from PR #2799. Commit eacf4f6 fixed three stale references in v4-0-0/basics/migrations.mdx; the same family of references still appeared in three siblings and is fixed here in one pass: - v4-0-0/basics/seeding.mdx:26 - v4-0-1-snapshot/basics/migrations.mdx:28,36,49 - v4-0-1-snapshot/basics/seeding.mdx:26 The on-disk table has been wheels_migrator_versions since the c_o_r_e_* → wheels_* rename; no schema_migrations table exists anywhere in vendor/wheels/, cli/, or app/. The line-49 fix in v4-0-1-snapshot/basics/migrations.mdx also mirrors the "keys on the filename" → "keys on the timestamp prefix" wording fix from eacf4f6, since the tracking table stores only the timestamp version (e.g., 20260420143000), not the full filename. v3-0-0/command-line-tools/cli-guides/migrations.md:632-633 intentionally left as-is: v3 used a different table name pre-rename, so the references are historical and accurate. Verified: \`grep -rn schema_migrations web/sites/guides/src/content/docs/v4-0-0 web/sites/guides/src/content/docs/v4-0-1-snapshot\` now returns zero matches. Refs #2780, #2798, #2799 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Peter Amiri <peter@alurium.com>
There was a problem hiding this comment.
Wheels Bot — Reviewer A
TL;DR: Pure documentation fix propagating the schema_migrations → wheels_migrator_versions rename to three v4 doc files missed in #2799. All five substitutions are accurate, the scope is exactly right (v3 historical references intentionally preserved), and the additional wording fix at v4-0-1-snapshot line 49 is technically correct. Verdict: approve.
Correctness
All five changes verified against the framework source:
wheels_migrator_versionsis the live table name — confirmed atvendor/wheels/events/onapplicationstart.cfc:253andvendor/wheels/Migrator.cfc:1055.- "keys on the timestamp prefix" (v4-0-1-snapshot/basics/migrations.mdx line 49) is accurate:
$sanitiseVersion()atvendor/wheels/Migrator.cfc:1067-1069strips all non-numeric characters from the filename, so20260420143000_create_posts_table.cfcyields20260420143000— the timestamp only, not the full filename. The previous wording "keys on the filename" was a latent inaccuracy that this PR corrects in the snapshot. grep -rn schema_migrations web/sites/guides/src/content/docs/v4-0-0 web/sites/guides/src/content/docs/v4-0-1-snapshotreturns zero matches.- v3 references at
v3-0-0/command-line-tools/cli-guides/migrations.md:632-633preserved — correct, as v3 predates the rename.
Commits
Single commit 87d558: type docs (valid), subject 86 characters (under limit), body explains the why thoroughly, Signed-off-by trailer present. Clean.
Docs
The CI docs build check in the test plan is unchecked — worth watching for the Astro/Starlight content lint pass, but not a blocker for approval given the changes are straightforward string substitutions in prose (no MDX component syntax touched).
Wheels Bot — Reviewer B (round 1)A's review checks out. Citations verified against source, no sycophancy, no false positives, no missed issues. Approve verdict is well-supported. SycophancyNone detected. Approval is backed by explicit source citations: False positivesNone detected. Every claim A made holds:
Missed issuesNone detected. The scope is five string substitutions in MDX doc files with no code, schema, or test surface. The wording fix at v4-0-1-snapshot/basics/migrations.mdx line 49 is technically correct given Verdict alignmentApprove is consistent with the findings: pure docs fix, all substitutions source-verified, no actionable concerns. ConvergenceAligned. A's evidence-backed approve is correct for this change. No changes needed. |
Summary
Carryover from #2799. Commit eacf4f6fc fixed three stale
schema_migrationsreferences in v4-0-0/basics/migrations.mdx. Reviewer A flagged the family on round 4 of #2799 as worth a follow-up; this PR cleans up the three siblings that were deferred:The on-disk table has been
wheels_migrator_versionssince thec_o_r_e_*→wheels_*rename; noschema_migrationstable exists anywhere invendor/wheels/,cli/, orapp/.The line-49 fix in
v4-0-1-snapshot/basics/migrations.mdxalso mirrors the "keys on the filename" → "keys on the timestamp prefix" wording fix from eacf4f6 — the tracking table stores only the timestamp version (e.g.,20260420143000), not the full filename.v3-0-0/command-line-tools/cli-guides/migrations.md:632-633 intentionally left as-is: v3 used a different table name pre-rename, so the references there are historical and accurate.
Refs #2780, #2798, #2799.
Test plan
grep -rn schema_migrations web/sites/guides/src/content/docs/v4-0-0 web/sites/guides/src/content/docs/v4-0-1-snapshotreturns zero matchesv3-0-0/command-line-tools/cli-guides/migrations.md:632-633preserved🤖 Generated with Claude Code