Skip to content

docs: propagate schema_migrations → wheels_migrator_versions rename to sibling v4 docs#2801

Merged
bpamiri merged 1 commit into
developfrom
claude/vigorous-morse-2cbf11
May 23, 2026
Merged

docs: propagate schema_migrations → wheels_migrator_versions rename to sibling v4 docs#2801
bpamiri merged 1 commit into
developfrom
claude/vigorous-morse-2cbf11

Conversation

@bpamiri
Copy link
Copy Markdown
Collaborator

@bpamiri bpamiri commented May 22, 2026

Summary

Carryover from #2799. Commit eacf4f6fc fixed three stale schema_migrations references in v4-0-0/basics/migrations.mdx. Reviewer A flagged the family on round 4 of #2799 as worth a follow-up; this PR cleans up the three siblings that were deferred:

The on-disk table has been wheels_migrator_versions since the c_o_r_e_*wheels_* rename; no schema_migrations table exists anywhere in vendor/wheels/, cli/, or app/.

The line-49 fix in v4-0-1-snapshot/basics/migrations.mdx also mirrors the "keys on the filename" → "keys on the timestamp prefix" wording fix from eacf4f6 — the tracking table stores only the timestamp version (e.g., 20260420143000), not the full filename.

v3-0-0/command-line-tools/cli-guides/migrations.md:632-633 intentionally left as-is: v3 used a different table name pre-rename, so the references there are historical and accurate.

Refs #2780, #2798, #2799.

Test plan

  • grep -rn schema_migrations web/sites/guides/src/content/docs/v4-0-0 web/sites/guides/src/content/docs/v4-0-1-snapshot returns zero matches
  • v3 historical references at v3-0-0/command-line-tools/cli-guides/migrations.md:632-633 preserved
  • CI green on docs build (Astro/Starlight content lint)

🤖 Generated with Claude Code

…o sibling v4 docs

Carryover from PR #2799. Commit eacf4f6 fixed three stale references in
v4-0-0/basics/migrations.mdx; the same family of references still appeared
in three siblings and is fixed here in one pass:

  - v4-0-0/basics/seeding.mdx:26
  - v4-0-1-snapshot/basics/migrations.mdx:28,36,49
  - v4-0-1-snapshot/basics/seeding.mdx:26

The on-disk table has been wheels_migrator_versions since the
c_o_r_e_* → wheels_* rename; no schema_migrations table exists anywhere
in vendor/wheels/, cli/, or app/.

The line-49 fix in v4-0-1-snapshot/basics/migrations.mdx also mirrors the
"keys on the filename" → "keys on the timestamp prefix" wording fix from
eacf4f6, since the tracking table stores only the timestamp version
(e.g., 20260420143000), not the full filename.

v3-0-0/command-line-tools/cli-guides/migrations.md:632-633 intentionally
left as-is: v3 used a different table name pre-rename, so the references
are historical and accurate.

Verified: \`grep -rn schema_migrations web/sites/guides/src/content/docs/v4-0-0 web/sites/guides/src/content/docs/v4-0-1-snapshot\` now returns zero matches.

Refs #2780, #2798, #2799

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Peter Amiri <peter@alurium.com>
Copy link
Copy Markdown
Contributor

@wheels-bot wheels-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wheels Bot — Reviewer A

TL;DR: Pure documentation fix propagating the schema_migrationswheels_migrator_versions rename to three v4 doc files missed in #2799. All five substitutions are accurate, the scope is exactly right (v3 historical references intentionally preserved), and the additional wording fix at v4-0-1-snapshot line 49 is technically correct. Verdict: approve.

Correctness

All five changes verified against the framework source:

  • wheels_migrator_versions is the live table name — confirmed at vendor/wheels/events/onapplicationstart.cfc:253 and vendor/wheels/Migrator.cfc:1055.
  • "keys on the timestamp prefix" (v4-0-1-snapshot/basics/migrations.mdx line 49) is accurate: $sanitiseVersion() at vendor/wheels/Migrator.cfc:1067-1069 strips all non-numeric characters from the filename, so 20260420143000_create_posts_table.cfc yields 20260420143000 — the timestamp only, not the full filename. The previous wording "keys on the filename" was a latent inaccuracy that this PR corrects in the snapshot.
  • grep -rn schema_migrations web/sites/guides/src/content/docs/v4-0-0 web/sites/guides/src/content/docs/v4-0-1-snapshot returns zero matches.
  • v3 references at v3-0-0/command-line-tools/cli-guides/migrations.md:632-633 preserved — correct, as v3 predates the rename.

Commits

Single commit 87d558: type docs (valid), subject 86 characters (under limit), body explains the why thoroughly, Signed-off-by trailer present. Clean.

Docs

The CI docs build check in the test plan is unchecked — worth watching for the Astro/Starlight content lint pass, but not a blocker for approval given the changes are straightforward string substitutions in prose (no MDX component syntax touched).

@wheels-bot
Copy link
Copy Markdown
Contributor

wheels-bot Bot commented May 22, 2026

Wheels Bot — Reviewer B (round 1)

A's review checks out. Citations verified against source, no sycophancy, no false positives, no missed issues. Approve verdict is well-supported.

Sycophancy

None detected. Approval is backed by explicit source citations: onapplicationstart.cfc:253, Migrator.cfc:1055, and Migrator.cfc:1067-1069 — all independently verified and accurate.

False positives

None detected. Every claim A made holds:

  • wheels_migrator_versions is correct at both cited lines.
  • $sanitiseVersion() at lines 1067-1069 is ReReplaceNoCase(version, "[^0-9]", "", "all") — strips all non-numeric characters, confirming the timestamp-prefix-only tracking claim.
  • The grep zero-result assertion is consistent with the diff (all five schema_migrations occurrences in v4-0-0 and v4-0-1-snapshot are replaced).
  • v3 preservation is correct — the diff touches no v3 files.

Missed issues

None detected. The scope is five string substitutions in MDX doc files with no code, schema, or test surface. The wording fix at v4-0-1-snapshot/basics/migrations.mdx line 49 is technically correct given $sanitiseVersion(). No other v4 doc directories exist that would require further cleanup.

Verdict alignment

Approve is consistent with the findings: pure docs fix, all substitutions source-verified, no actionable concerns.

Convergence

Aligned. A's evidence-backed approve is correct for this change. No changes needed.

@bpamiri bpamiri merged commit c7a3516 into develop May 23, 2026
13 of 14 checks passed
@bpamiri bpamiri deleted the claude/vigorous-morse-2cbf11 branch May 23, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant