fix: add retry logic for WebSocket connection to SQL session#65
Merged
fix: add retry logic for WebSocket connection to SQL session#65
Conversation
Contributor
Author
|
@salty-hambot roast me |
![salty-hambot[bot]](https://avatars.githubusercontent.com/in/2952321?s=60&v=4){kind=small}
There was a problem hiding this comment.
Reviewed by Salty Hambot 🤖🧂
Retry logic works but casts too wide a net — OSError will happily retry permission denied errors and DNS failures, and the SSL setup is needlessly re-executed (and mis-caught) on each attempt.
2 finding(s) posted.
💬 To request a re-review, comment @salty-hambot review
Adds tenacity-based retry with exponential backoff to the initial WebSocket connection in connect_direct(). This fixes intermittent failures in the SQL session canary tests caused by transient connection errors during the WebSocket handshake. Bump version to 0.26.1.
sfishel18
force-pushed
the
simon/ws-connect-retry
branch
from
0bc3d49 to
89929dc
Compare
Contributor
Author
|
@salty-hambot roast me |
ClayMav
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connect_direct()ConnectionRefusedError,TimeoutError,OSError,InvalidHandshake)Fixes intermittent failures in the SQL session canary tests caused by transient connection errors during the WebSocket handshake.