Skip to content

Node#clone returns self (they're immutable, after all) #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2015
Merged

Node#clone returns self (they're immutable, after all) #12

merged 2 commits into from
Oct 30, 2015

Conversation

@alexdowad
Copy link
Contributor

@alexdowad alexdowad commented Oct 30, 2015

Since Node#dup returns self, it makes sense for Node#clone to do the same. (In core Ruby, dup copies an object's "frozen" and "tainted" status, and clone doesn't.)

whitequark added a commit that referenced this pull request Oct 30, 2015
@whitequark
Merge pull request #12 from alexdowad/alex
63db468 
`Node#clone` returns self (they're immutable, after all)
@whitequark whitequark merged commit 63db468 into whitequark:master Oct 30, 2015
@alexdowad
Copy link
Contributor Author

alexdowad commented Oct 30, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexdowad @whitequark