Run tests on Ruby 2.1.0 and ruby-head #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitequark
added a commit
that referenced
this pull request
Apr 30, 2014
Run tests on Ruby 2.1.0 and ruby-head
Collaborator
There was a problem hiding this comment.
I'd suggest to also test against 2.1.1. This release is IMO more stable than 2.1.0.
Collaborator
Author
There was a problem hiding this comment.
Haven't noticed any problems with RuboCop's builds on 2.1.0 so far, but maybe it makes sense to always use the latest bugfix release.
Collaborator
There was a problem hiding this comment.
I had lots of crashes / segfaults on 2.1.0, that had been fixed with 2.1.1.
Owner
|
This PR actually breaks the Travis build somehow: https://travis-ci.org/whitequark/parser/jobs/24107407 https://travis-ci.org/whitequark/parser/jobs/24107411 |
whitequark
added a commit
that referenced
this pull request
May 1, 2014
Contributor
|
@whitequark I've seen similar errors on Travis in the past few days on my own projects. They started occurring suddenly so I think Travis goof'd somehow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title says it all. I noticed you weren't running the tests on 2.1 and ruby-head when I saw this https://travis-ci.org/bbatsov/rubocop/jobs/24101781