Capture delimiter in percent encoded literals #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This commit includes some other stuff, will redo it, sorry for the noise. |
Collaborator
Author
|
Fixed, should not result in coverage decrease! |
Owner
There was a problem hiding this comment.
Parser follows the GitHub style guide, which instructs to never use and and or.
Owner
There was a problem hiding this comment.
Also, #end_with? is much more clear in this case.
Owner
There was a problem hiding this comment.
Not only it is more clear, it also fixes a bug :)
1) Failure:
TestLexer#test_regexp_escape_backslash_terminator [/home/whitequark/parser/test/test_lexer.rb:71]:
%r%blah\%blah%.
Expected: [:tREGEXP_BEG, "%r"]
Actual: [:tREGEXP_BEG, "%r%"]
Collaborator
Author
There was a problem hiding this comment.
I followed dkubb styleguide, no problem for me to use the GH styleguide here.
Contributor
There was a problem hiding this comment.
@mbj I'm not sure I would've used and or or in a boolean statement either :P
Collaborator
Author
There was a problem hiding this comment.
@dkubb I remember I nitpicked about this some time :P
whitequark
added a commit
that referenced
this pull request
Apr 13, 2013
Capture delimiter in percent encoded literals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the missing
(in%W()style literals.