Skip to content

feat: custom clases for the notification list component #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2023
Merged

feat: custom clases for the notification list component #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
131b731
feat: custom clases for the notification list component
Michael-Liendo May 9, 2023
feb1412
refactor: Update src/lib/components/NotificationList.svelte
Michael-Liendo May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,12 @@ describe('getPositionClasses', () => {
expect(getPositionClasses(Position.BottomLeft)).toBe('bottom-6 left-6');
});
});

describe('Custom Classes', () => {
it('renders correctly with custom class', () => {
const { container } = render(NotificationList, {
class: 'custom-class'
});
expect(container.querySelector('.custom-class')).not.toBeNull();
});
});
5 changes: 4 additions & 1 deletion src/lib/components/NotificationList.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@

let notificationsList: INotification[] = [];

let className = '';
export { className as class };

export let position: Position = Position.TopRight;

// Use auto-subscriptions to avoid leaking memory on re-renders
Expand All @@ -43,7 +46,7 @@
</script>

<ul
class={`fixed p-6 space-y-4 overflow-y-auto max-h-[calc(100vh-54px)] ${getPositionClasses(
class={`fixed p-6 space-y-4 overflow-y-auto max-h-[calc(100vh-54px)] ${className} ${getPositionClasses(
position
)}`}
class:z-10={notificationsList?.length}
Expand Down