Skip to content

release: 0.0.20#24

Merged
cnrstvns merged 6 commits intomainfrom
release-please--branches--main--changes--next
Dec 16, 2025
Merged

release: 0.0.20#24
cnrstvns merged 6 commits intomainfrom
release-please--branches--main--changes--next

Conversation

@stainless-app
Copy link
Copy Markdown
Contributor

@stainless-app stainless-app Bot commented Dec 12, 2025

Automated Release PR

0.0.20 (2025-12-16)

Full Changelog: v0.0.19...v0.0.20

Features

Chores

  • internal: add missing files argument to base client (f921d8e)
  • speedup initial import (d90ab37)

This pull request is managed by Stainless's GitHub App.

The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.

For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.

🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions

@stainless-app
Copy link
Copy Markdown
Contributor Author

stainless-app Bot commented Dec 12, 2025

🧪 Testing

To try out this version of the SDK, run:

pip install 'https://pkg.stainless.com/s/whopsdk-python/12958bfaaf8b08a2b771e565a0685ec547e44bd1/whop_sdk-0.0.19-py3-none-any.whl'

Expires at: Thu, 15 Jan 2026 17:32:23 GMT
Updated at: Tue, 16 Dec 2025 17:32:23 GMT

@stainless-app stainless-app Bot force-pushed the release-please--branches--main--changes--next branch from cf3e64a to 81409a0 Compare December 15, 2025 19:23
Comment thread src/whop_sdk/_base_client.py
@stainless-app stainless-app Bot force-pushed the release-please--branches--main--changes--next branch from 81409a0 to b5916d5 Compare December 15, 2025 19:32
@stainless-app stainless-app Bot force-pushed the release-please--branches--main--changes--next branch from b5916d5 to efb1b1d Compare December 16, 2025 17:24
@stainless-app stainless-app Bot force-pushed the release-please--branches--main--changes--next branch from efb1b1d to 90a010d Compare December 16, 2025 17:31
@cnrstvns cnrstvns changed the title release: 0.1.0 release: 0.0.20 Dec 16, 2025
@stainless-app
Copy link
Copy Markdown
Contributor Author

stainless-app Bot commented Dec 16, 2025

Release version edited manually

The Pull Request version has been manually set to 0.0.20 and will be used for the release.

If you instead want to use the version number 0.1.0 generated from conventional commits, just remove the label autorelease: custom version from this Pull Request.

@stainless-app stainless-app Bot force-pushed the release-please--branches--main--changes--next branch from 90a010d to 4617767 Compare December 16, 2025 17:41
@cnrstvns cnrstvns merged commit 7c6cc08 into main Dec 16, 2025
8 checks passed
@stainless-app
Copy link
Copy Markdown
Contributor Author

stainless-app Bot commented Dec 16, 2025

Comment on lines +26 to +27
from ..types.shared.business_types import BusinessTypes
from ..types.shared.industry_types import IndustryTypes
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The async patch method calls the synchronous to_httpx_files function instead of awaiting the correct async_to_httpx_files function, unlike other async methods.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The AsyncAPIClient.patch method at src/whop_sdk/_base_client.py:1777 incorrectly calls the synchronous function to_httpx_files(files) within an async context. This is inconsistent with other async methods like post and put, which correctly await the async_to_httpx_files(files) coroutine. Calling the synchronous version can block the event loop and will not properly handle async file objects, leading to incorrect file handling or runtime errors when performing an async patch request with file uploads.

💡 Suggested Fix

In the AsyncAPIClient.patch method, change the call from to_httpx_files(files) to await async_to_httpx_files(files). This will ensure non-blocking, asynchronous file handling, consistent with the post and put async methods.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: src/whop_sdk/resources/companies.py#L26-L27

Potential issue: The `AsyncAPIClient.patch` method at
`src/whop_sdk/_base_client.py:1777` incorrectly calls the synchronous function
`to_httpx_files(files)` within an async context. This is inconsistent with other async
methods like `post` and `put`, which correctly `await` the `async_to_httpx_files(files)`
coroutine. Calling the synchronous version can block the event loop and will not
properly handle async file objects, leading to incorrect file handling or runtime errors
when performing an async patch request with file uploads.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7602218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant