feat: modules can be imported from a url#80
Merged
Conversation
maartenbreddels
force-pushed
the
feat/url-modules
branch
2 times, most recently
from
c49d37b to
eba1a5f
Compare
define_module(name, url="/static/bundle.mjs") imports the module from the url instead of shipping the code over the widget model (e.g. a bundle served from the app's static dir, cacheable and preloadable). Exactly one of module (a Path), code= or url= must be passed; a plain str still works as module code for backwards compatibility, with a DeprecationWarning. Note: under solara server define_module is patched by solara.server.esm, which needs the matching update (widgetti/solara#1169) for the new signature to apply there. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
maartenbreddels
force-pushed
the
feat/url-modules
branch
from
eba1a5f to
14a9cc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
define_modulegains explicit sources: exactly one ofmodule(aPath),code=orurl=. A url-backed module is imported by the browser from that url instead of shipping the code over the widget model — e.g. a bundle served from the app's static dir, cacheable and preloadable (solara adds?v=<content-hash>+ immutable headers and a<link rel=modulepreload>in widgetti/solara#1169). TheModulewidget gets aurltrait;change:urlhot-swaps likechange:code.Backwards compatible: a plain str still works as module code (the released API) with a
DeprecationWarningpointing atcode=. Unit tests cover all forms plus the error cases; existing module UI tests pass unchanged.Note: under solara server,
define_moduleis patched bysolara.server.esm— released solara keeps working via the deprecated form; the new keywords apply there once widgetti/solara#1169 ships.🤖 Generated with Claude Code