Merged
Conversation
Picks up asobi PR #85: lobby find_or_create race fix and zone snapshot persistence fix. Without this bump, the published asobi_lua image still ships the broken lobby (concurrent clients land in different worlds for the same mode) and the silently-failing zone snapshot writes (cast errors swallowed as warning logs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the locked
asobiref toaf29781(asobi PR #85).Picks up two production fixes:
find_or_create/1race: concurrent clients asking for the samemodeno longer land in different worlds (TOCTOU fixed by serializing throughasobi_world_lobby_server)snapshot_atcast failure + multi-columnON CONFLICTagainst a unique INDEX (not CONSTRAINT)Without this bump, the published
ghcr.io/widgrensit/asobi_luaimage keeps shipping the broken behavior; barrow and other consumers stay on the bad code path.Test plan
rebar3 fmt --checkrebar3 xrefrebar3 dialyzer~/bin/elp eqwalize-allno new errors (24 pre-existing on main)rebar3 eunit61/61dev_sys.config.srcuses runtime${ASOBI_*}placeholders); CI handles substitution