chore(lua): migrate logger:fun calls to ?LOG_* macros#45
Merged
Conversation
20 logger:error/warning/notice function calls across asobi_lua_match,
asobi_lua_world, asobi_lua_reload, and asobi_lua_api swapped for the
OTP report-form macros, with -include_lib("kernel/include/logger.hrl")
added to each module.
No behaviour change; the macros take the same map/format arguments.
Project convention per the team's pre-push checklist prefers macros so
the compiler injects file/line/module metadata into every log entry
without each call repeating it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Followup from #44 (the code reviewer flagged the pre-existing drift but recommended a separate cleanup PR to keep the bisect clean).
Test plan