Enable use on all Wikipedias#34
Merged
Niharika29 merged 1 commit intowikimedia:masterfrom Nov 7, 2016
samwilson:multiwiki2
Merged
Enable use on all Wikipedias#34Niharika29 merged 1 commit intowikimedia:masterfrom samwilson:multiwiki2
Niharika29 merged 1 commit intowikimedia:masterfrom
samwilson:multiwiki2
Conversation
Collaborator
|
Hmm, the number formatting doesn't seem to be working in French. Currently, I see: "Compteur d'édition : 22,594", but I assume that should be "Compteur d'édition : 22 594". Also "4,055 mots". |
Member
Author
|
Oops! It was because the Twig number formatting was being configured in route middleware that was never being loaded. I've moved it into |
This change updates CopyPatrol to work on all language Wikipedias that are supported by EranBot. Primarily it focusses on getting things working with French (for which translations are encluded here) but with the exception of the WikiProject prefix cleanup in index.js there's now nothing here specific to any one language. Upgrading to this will require a couple of changes in the .env file, and running `composer install`. Bug: https://phabricator.wikimedia.org/T145436
Member
Author
|
Numbers display correctly now: http://tools.wmflabs.org/plagiabot/en/leaderboard?uselang=fr |
Collaborator
|
This looks great and works nicely. I'm going to merge this but let's not deploy it until we have Eranbot active on frwiki and musikbot configured all fine. |
Member
Author
|
Sounds good. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates CopyPatrol to work on all language
Wikipedias that are supported by EranBot. Primarily it
focusses on getting things working with French (for
which translations are encluded here) but with the
exception of the WikiProject prefix cleanup in index.js
there's now nothing here specific to any one language.
Upgrading to this will require a couple of changes in
the .env file, and running
composer install.Bug: https://phabricator.wikimedia.org/T145436
This PR replaces #32 and squashes everything into one commit.