Conversation
| $langs = $this->getPlagiabotDao()->getLanguages(); | ||
| $cacheItem->expiresAfter( new DateInterval( 'P7D' ) ); | ||
| $cacheItem->set( $langs ); | ||
| $this->slim->cache->save( $cacheItem ); |
There was a problem hiding this comment.
Can't remember, where does the Slim cache live? In a cookie?
There was a problem hiding this comment.
No, Redis when in production, or a local file-based cache when in development (or any time we don't have REDIS_HOST defined).
|
|
||
| // Otherwise get the list from the database, and cache it for a week. | ||
| $langs = $this->getPlagiabotDao()->getLanguages(); | ||
| $cacheItem->expiresAfter( new DateInterval( 'P7D' ) ); |
There was a problem hiding this comment.
maybe also explain what P7D is. I'm safely guessing 7D = 7 days, but what does the P do?
There was a problem hiding this comment.
It's the interval_spec, quite redundant really, I guess their aiming at future compatibility with things. I think it's also something to do with ISO8601 (with the 'T' being a delimiter for the time component)....
The format starts with the letter P, for "period." Each duration period is represented by an integer value followed by a period designator. If the duration contains time elements, that portion of the specification is preceded by the letter T.
I'll make a comment about the format meaning.
| 'app' => $this->slim, | ||
| 'i18nCtx' => $this->slim->i18nContext | ||
| 'i18nCtx' => $this->slim->i18nContext, | ||
| 'supportedLanguages' => $this->getSupportedLanguages(), |
There was a problem hiding this comment.
does the trailing comma violate any coding conventions (not sure)? I know some organizations prefer it this way
There was a problem hiding this comment.
The mediawiki-codesniffer master doesn't complain about it, and I like doing trailing commas in multi-line arrays becuase it means the next time something gets added the diff then shows an actual meaningful change of 1 line.
There was a problem hiding this comment.
Yeah I like it too :) As long as the codesniffer is happy, you don't want to upset it
There was a problem hiding this comment.
Talking of codesniffer, do you fancy reviewing this? https://gerrit.wikimedia.org/r/#/c/324376/ :-)
There was a problem hiding this comment.
We don't have any coding conventions against trailing commas in PHP, in fact, this is probably the more common style in MediaWiki as it helps to prevent accidental syntax errors when adding new items to arrays. Of course, you have to be careful not to do this in JavaScript though.
samwilson
force-pushed
the
lang-list
branch
2 times, most recently
from
41899fc to
267beaa
Compare
|
I've added messages for all languages supported by Turnitin (for the future). |
The list of languages supported by CopyPatrol is retrieved from the database, and cached for 7 days. The dropdown list in the navbar now lists all these. Translations for all Wikipedias' titles have been added. The phpcs change is just to ignore the cache directory that exists for local development. Bug: https://phabricator.wikimedia.org/T152362
kaldari
left a comment
kaldari
left a comment
There was a problem hiding this comment.
+1, looks good to me, but haven't tested.
3 participants
The list of languages supported by CopyPatrol is retrieved from
the database, and cached for 7 days. The dropdown list in the
navbar now lists all these.
The phpcs change is just to ignore the cache directory that
exists for local development.
Bug: https://phabricator.wikimedia.org/T152362