Make revision link more discoverable and less clicky#108
Closed
Make revision link more discoverable and less clicky#108
Conversation
added 6 commits
August 15, 2019 11:58
Previously, the entire header was a giant link. This removes the link functionality. I've added back an icon that links to the revision but I didn't do something similar for the user. We can add that back in a future patch. I expect there to be opinions about the icon and its placement. Bug: T194439
We no longer use the Link component in this module.
I've just put it on the icon for now.
Also, I learned how to run `npm test` locally.
Member
davidbarratt
left a comment
davidbarratt
left a comment
There was a problem hiding this comment.
I'm not a fan of this change because it feels unnecessary. I'm curious what @prtksxna thinks.
Author
|
We could abandon this now, I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the entire header was a giant link. This removes the
link functionality. I've added back an icon that links to the revision
but I didn't do something similar for the user. We can add that back
in a future patch.
I expect there to be opinions about the icon and its placement.
Bug: T194439