Change Intuition::msg() to check all domains for messages#52
Merged
Conversation
samwilson
force-pushed
the
use-all-domains
branch
from
4520649 to
bcfeeac
Compare
The bundle comes with some i18n messages, and they've not been usable via Twig because we've been setting the Intuition domain to only one value and the bundle's messages are under the 'toolforge' domain. This change is to loop through all registered domains (i.e. two of them, in the usual case), and return the first matched message. Bug: T273840
samwilson
force-pushed
the
use-all-domains
branch
from
bcfeeac to
3043e33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundle comes with some i18n messages, and they've not been usable
via Twig because we've been setting the Intuition domain to only
one value and the bundle's messages are under the 'toolforge' domain.
This change is to loop through all registered domains (i.e. two of
them, in the usual case), and return the first matched message.
Bug: T273840