Skip to content

fixed the URI for development#185

Merged
srish merged 2 commits into
wikimedia:masterfrom
sanyam-git:patch-1
Apr 17, 2020
Merged

fixed the URI for development#185
srish merged 2 commits into
wikimedia:masterfrom
sanyam-git:patch-1

Conversation

@sanyam-git
Copy link
Copy Markdown
Contributor

minor fix in readme file

@NdibeRaymond
Copy link
Copy Markdown
Collaborator

@sanyam-git the process has been automated so that line is no longer necessary. What you can do is delete the whole line (Inorder to make the frontend send requests to the local backend, you need to change the code in the file frontend/WikiContrib-Frontend/src/api.js and change the value of BASE_API_URI to http://127.0.0.1:8000/)
then update your PR

@sanyam-git
Copy link
Copy Markdown
Contributor Author

Thanks @NdibeRaymond, checked and removed the line from doc.

@srish srish self-requested a review April 13, 2020 21:58
@srish srish merged commit 7b1ea6e into wikimedia:master Apr 17, 2020
@srish
Copy link
Copy Markdown
Member

srish commented Apr 17, 2020

Thank you @NdibeRaymond for your feedback and @sanyam-git for your first PR to the project :)

@sanyam-git sanyam-git deleted the patch-1 branch April 20, 2020 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants