This repository was archived by the owner on May 15, 2024. It is now read-only.
Extend “Icons” section with further agreed-on rules#45
Merged
jandre3000 merged 2 commits intomasterfrom Jun 30, 2017
Merged
Conversation
Contributor
|
Hey Volker, I tried to update but do not appear to have permissions. Here's the updates I made to this file, plus updated icon images attached. |
Collaborator
Author
|
@reetssydney You mean to update this PR, correct? |
Contributor
|
@Volker-E yes please! |
Collaborator
Author
|
@reetssydney Do you have the imagery as SVGs as well? Or should this wait till @nirzar provides the huge SVG imagery file™? |
Contributor
Extending “Icons” section with further agreed-on rules, fixing typos, normalize way dimension values are written and update images.
Volker-E
force-pushed
the
extend-icons-section-20170613
branch
from
9fbbd54 to
ac95d5f
Compare
Collaborator
Author
|
@reetssydney Ok, thanks! Minor note for future PRs: We should always avoid inline styles, they are neither well-performing, nor scalable. Left it in, because otherwise patch would get too far reaching. But this needs general approach! |
jandre3000
approved these changes
Jun 30, 2017
Ladsgroup
pushed a commit
that referenced
this pull request
Oct 9, 2019
* Extend “Icons” section with further agreed-on rules Extending “Icons” section with further agreed-on rules, fixing typos, normalize way dimension values are written and update images. * Amend and extend “References” section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.