Skip to content
This repository was archived by the owner on Nov 13, 2025. It is now read-only.

Updates for running with nodejs 18#22

Merged
ottomata merged 2 commits intowikimedia:masterfrom
ottomata:T347477_upgrade_node
Oct 5, 2023
Merged

Updates for running with nodejs 18#22
ottomata merged 2 commits intowikimedia:masterfrom
ottomata:T347477_upgrade_node

Conversation

@ottomata
Copy link
Contributor

@ottomata ottomata commented Oct 4, 2023

Mostly we need a node-rdkafka version update.
To do this, we need an upgrade of @wikimedia/node-rdkafka-factory.

Depends-On: https://gerrit.wikimedia.org/r/c/node-rdkafka-factory/+/963411
Bug: T347477

@ottomata ottomata requested a review from elukey October 4, 2023 20:59
commit 443995586b1bdb20d4b8bab783cae4ccee2bfad6
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Jul 19 12:45:52 2023 +0000

    Bump word-wrap from 1.2.3 to 1.2.4

    Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
    - [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
    - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

    ---
    updated-dependencies:
    - dependency-name: word-wrap
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

commit df596d50a1415421f20b0fe0cd74ec3edd2f5588
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Dec 15 05:38:20 2022 +0000

    Bump express from 4.17.1 to 4.17.3

    Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.17.3.
    - [Release notes](https://github.com/expressjs/express/releases)
    - [Changelog](https://github.com/expressjs/express/blob/master/History.md)
    - [Commits](expressjs/express@4.17.1...4.17.3)

    ---
    updated-dependencies:
    - dependency-name: express
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

commit d8e288b164b6164836d3f7f60da791b48118788a
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Jan 9 14:37:51 2023 +0000

    Bump qs from 6.5.2 to 6.5.3

    Bumps [qs](https://github.com/ljharb/qs) from 6.5.2 to 6.5.3.
    - [Release notes](https://github.com/ljharb/qs/releases)
    - [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
    - [Commits](ljharb/qs@v6.5.2...v6.5.3)

    ---
    updated-dependencies:
    - dependency-name: qs
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

commit 3e3520067823afcd9574d4e71192e3e23559f6da
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Sun Jan 8 23:31:21 2023 +0000

    Bump json5 from 2.2.1 to 2.2.3

    Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3.
    - [Release notes](https://github.com/json5/json5/releases)
    - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
    - [Commits](json5/json5@v2.2.1...v2.2.3)

    ---
    updated-dependencies:
    - dependency-name: json5
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

commit 529f14af5c295ad8e36e8064e26a0ba8280e3361
Author: James D. Forrester <jforrester@wikimedia.org>
Date:   Tue Nov 15 17:41:47 2022 -0500

    build: Upgrade eslint-config-wikimedia to 0.23.0

commit c715356ebd1cb4285dff35447b03e38b9faf277d
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Nov 15 22:31:28 2022 +0000

    Bump minimatch from 3.0.4 to 3.1.2

    Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.0.4 to 3.1.2.
    - [Release notes](https://github.com/isaacs/minimatch/releases)
    - [Commits](isaacs/minimatch@v3.0.4...v3.1.2)

    ---
    updated-dependencies:
    - dependency-name: minimatch
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

commit c4dc28c699190dec5f95725e454695306f80cabc
Author: Chris Danis <cdanis@wikimedia.org>
Date:   Tue Nov 15 14:56:56 2022 -0500

    Propagate TraceContext headers

    Similar to T225711 & a92cccea, propagate the two W3C TraceContext
    headers to any sub-requests made.

    Propagating these two headers without modifying them or even parsing
    them is allowed by the W3C TraceContext Recommendation:
    https://www.w3.org/TR/trace-context/#design-overview

    Bug: T320561

commit 6431a9964bf05579d4419af36266a305be3014e5
Author: Marielle Volz <marielle.volz@gmail.com>
Date:   Tue Jul 19 15:05:11 2022 +0100

    blubber: Use python and pkg-config packages; python-pkgconfig doesn't exist on bullseye

    Use separate python and pkg-config packages
    as python-pkgconfig is not available for node 12

commit ae32469a93fc584aa92203d3c88b095f1c34f8af
Author: James D. Forrester <jforrester@wikimedia.org>
Date:   Mon May 30 21:28:30 2022 -0400

    Upgrade service-runner to 3.1.0

commit 778dc062acd7c050685ca5b6d34e15e65b6d3077
Author: James D. Forrester <jforrester@wikimedia.org>
Date:   Mon May 30 21:24:46 2022 -0400

    build: Upgrade ajv to non-security-alerting version

commit 3c8a30883b008879f0b56a474667815caccc8a02
Author: James D. Forrester <jforrester@wikimedia.org>
Date:   Thu Apr 28 11:55:31 2022 -0400

    build: Upgrade mocha and nyc to modern versions

commit f189ab90365934451d6c158ff335db9f76d3a2e8
Author: James D. Forrester <jforrester@wikimedia.org>
Date:   Tue Apr 26 12:00:00 2022 -0400

    Upgrade Swagger to 4.x

commit bbb13786a1977359f077ea0a5b00765409e446dd
Author: James D. Forrester <jforrester@wikimedia.org>
Date:   Thu Apr 7 20:28:45 2022 +0100

    eslint: Follow coding standard for indenting

commit 9cc423d126c6e03d97deee0a343bc248ea84f491
Author: James D. Forrester <jforrester@wikimedia.org>
Date:   Tue Apr 5 14:33:09 2022 +0100

    build: Run eslint on YAML files too and fix

commit 03c588d388c644ad04047017358caac0e85c4e8a
Author: James D. Forrester <jforrester@wikimedia.org>
Date:   Wed Apr 6 13:16:41 2022 +0100

    build: Upgrade eslint-config-wikimedia to 0.22.1 (#166)

commit 84721cf32505950920fd7ea64f3f173a4d0a6ac5
Author: James D. Forrester <jforrester@wikimedia.org>
Date:   Tue Apr 5 13:22:53 2022 +0100

    Target node12, up from node10

    Re-creation of #154 on the current HEAD.

commit 3c80e8ac7e741fa73884e1902f62ea3887513104
Author: James D. Forrester <jforrester@wikimedia.org>
Date:   Tue Apr 5 13:20:46 2022 +0100

    build: Add GH Actions to replace Travis for CI (#164)

    * build: Add GH Actions to replace Travis for CI

    * Commit package-lock.json so GitHub Actions works

    * build: Drop .travis.yml, we don't use it anymore

commit 3d5ec9ddd530143d7f62c2bc16ab8869768bbecd
Author: James D. Forrester <jforrester@wikimedia.org>
Date:   Tue Jan 18 10:14:23 2022 -0500

    Release v0.11.0

    Changes since v0.10.0:
    * Avoid unncessary use of ableist language (James D. Forrester)
    * Update router metric to Histogram & use toggleable service label for router metric (Cole White)
    * Upgrade service-runner to dev branch with new metrics api (Cole White)
    * Upgrade service-runner to v2.8.0 (Clara Andrew-Wani)
    * Upgrade service-runner to v2.8.3 (Kosta Harlan)
    * Upgrade service-runner to v2.8.4 for prometheus label value fix (Ottomata)
    * Upgrade service-runner to v3.0.0 (node6 dropped) (James D. Forrester)
    * config: Replace gelf logging config (Cole White)
    * blubber: Add env specific config file (nikkhn)
    * blubber: Remove LINK env variable in default (Nikki Nikkhoui)

    * README: Add blubber cmd examples (nikkhn)
    * README: Add blurb about blubber and docker script deprecation (nikkhn)
    * README: Correct documented variable name (Nikki Nikkhoui)
    * README: Drop TravisCI badge (James D. Forrester)
    * README: Specify phab as issue tracker (Nikki Nikkhoui)
    * README: Typo fix, remove deprecated version num (nikkhn)

    * build: Simplify and modernise eslint configuration (James D. Forrester)
    * build: Update eslint-config-wikimedia and eslint-plugin-jsdoc doc dependency versions (Ottomata)
    * build: Upgrade eslint-config-wikimedia to v0.21.0 (James D. Forrester)

commit 5e4c7b994c571c98dca9f515a1e6a7a97f911cb9
Author: James D. Forrester <jforrester@wikimedia.org>
Date:   Tue Jan 18 10:18:09 2022 -0500

    build: Upgrade eslint-config-wikimedia to v0.21.0

commit 607a8d4d8f5abe2b4464e131f01d2e0b08b062b7
Author: James D. Forrester <jforrester@wikimedia.org>
Date:   Mon Nov 29 12:54:31 2021 -0500

    Avoid unncessary use of ableist language

commit 9551f8d4eab356a30e9215ef4b4a615989598034
Author: James D. Forrester <jforrester@wikimedia.org>
Date:   Tue Nov 9 15:07:34 2021 -0500

    Upgrade service-runner to v3.0.0 (node6 dropped)

    As part of https://phabricator.wikimedia.org/T295398 work.

commit f3c7ccfd0af55ae7072f47c3b0276cd3234247d7
Merge: 709e80c 2e62384
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Tue Nov 9 06:46:27 2021 -0800

    Merge pull request #161 from nikkhn/remove-LINK-env-var

    remove LINK env variable in default blubber.yaml

commit 2e6238479ddc377874765a29a306be5fd4cccab3
Author: Nikki Nikkhoui <nnikkhoui@wikimedia.org>
Date:   Mon Nov 8 15:01:25 2021 -0500

    remove LINK env variable in default blubber.yaml

commit 709e80cd3f4e023aa5b62757269ffe2c1751e9fb
Author: Cole White <42356806+shdubsh@users.noreply.github.com>
Date:   Thu Sep 2 14:15:54 2021 -0600

    Update config.prod.yaml to replace gelf logging config

commit 974a6016affe9b67759dd01ab281f32d3225cf36
Author: Nikki Nikkhoui <nnikkhoui@gmail.com>
Date:   Tue Aug 31 12:09:27 2021 -0400

    specify phab as issue tracker (#158)

    Co-authored-by: Eric Evans <eevans@wikimedia.org>

commit 7330ca2a8e6a897f6bcf58a02ff6f50c3d5a9ee5
Author: James D. Forrester <jforrester@wikimedia.org>
Date:   Tue Aug 10 11:30:09 2021 -0700

    README: Drop TravisCI badge

    We intentionally don't render foreign resources in our documentation,
    as it's a security vulnerability, so let's not encourage repos to use
    badges like this. (Also, travis-ci.*org* is no more, replaced by .com
    so this wouldn't work anyway.)

commit 0520be52d026e058625229a92c0f7c4b10101df3
Merge: 5d04694 841d86d
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Tue Jul 13 07:32:26 2021 -0700

    Merge pull request #156 from ottomata/prometheus

    Bump to service-runner 2.8.4 for prometheus label value fix

commit 841d86d34834fcd3b916d8642eddfe4acc3b389e
Author: Ottomata <aotto@wikimedia.org>
Date:   Tue Jul 13 10:31:00 2021 -0400

    Bump to service-runner 2.8.4 for prometheus label value fix

commit 5d0469417f1ca86e7631a9074186b60f0cd803a1
Merge: 9dd200d eef6448
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Mon Jul 12 11:41:28 2021 -0700

    Merge pull request #151 from wikimedia/eslint-0.20.0

    build: Simplify and modernise eslint configuration

commit eef6448d1e34eaae28eebc9f8198bb442492cebf
Author: James D. Forrester <jforrester@wikimedia.org>
Date:   Thu Apr 29 10:17:37 2021 -0700

    build: Simplify and modernise eslint configuration

    This brings things more in line with how repos downstream are
    generally using eslint.

    Suppressing some whines from the mocha test suite for now.

commit 9dd200d25f77442889f0cd9e96a749dddfcd34c4
Merge: 3c41126 c96c9ae
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Mon Jul 12 11:16:18 2021 -0700

    Merge pull request #155 from ottomata/prometheus

    Update service-template-node to service-runner 2.8.3 with prometheus support.

commit c96c9ae5400ec5f4c7a7c56be6254ccd18ad128c
Author: Ottomata <aotto@wikimedia.org>
Date:   Mon Jul 12 13:34:15 2021 -0400

    Update eslint-config-wikimedia and eslint-plugin-jsdoc doc dependency versions

commit 794c669776922d9395c564689354801e9ba218d4
Merge: c9cdcd6 0c64848
Author: Ottomata <aotto@wikimedia.org>
Date:   Mon Jul 12 13:17:23 2021 -0400

    Merge remote-tracking branch 'kostajh/patch-1' into prometheus

    Conflicts:
    	package.json

commit c9cdcd69c6cc92f470d2a1486c4f3dadedde28d5
Merge: a7ffe9c 3156477
Author: Ottomata <aotto@wikimedia.org>
Date:   Mon Jul 12 13:16:42 2021 -0400

    Merge remote-tracking branch 'origin/prometheus_metrics_pr' into prometheus

    Conflicts:
    	package.json

commit a7ffe9c2d909cacef4bcd2beb69107dc9670ddd2
Merge: 3c41126 c4c92be
Author: Ottomata <aotto@wikimedia.org>
Date:   Mon Jul 12 13:14:31 2021 -0400

    Merge remote-tracking branch 'clarokosi/master' into prometheus

    Conflicts:
    	package.json

commit 0c64848f8c66a0bf241158ffcb5d5618d5421a6d
Author: Kosta Harlan <kharlan@wikimedia.org>
Date:   Thu May 6 10:18:06 2021 +0200

    Bump service-runner to 2.8.3

    See wikimedia/service-runner/pull/237/files

commit 3c411268b4c59ddaab02256b8131b8934033fa65
Merge: 2608700 59270f0
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Mon May 3 13:13:19 2021 -0700

    Merge pull request #152 from nikkhn/Env-specific-blubber-config

    Add env specific config file to blubber.yaml

commit 59270f032baa733e7868aa9ccf525a2ce74a9625
Author: nikkhn <nnikkhoui@gmail.com>
Date:   Mon May 3 13:03:44 2021 -0500

    Add env specific config file to blubber.yaml

commit 2608700f8b91e10c810f417d1d764f499137e3e1
Merge: 5cf79c8 316696b
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Wed Apr 28 13:47:14 2021 -0700

    Merge pull request #150 from nikkhn/note-docker-deprecation-readme

    Add blurb about blubber and docker script deprecation

commit 316696ba65859c8e8ab971a867a4b528da894012
Author: Nikki Nikkhoui <nnikkhoui@gmail.com>
Date:   Wed Apr 28 16:45:26 2021 -0400

    Update README.md

commit 241c669c8d5ff2f4330c5084a037e67da079fe65
Author: nikkhn <nnikkhoui@gmail.com>
Date:   Wed Apr 28 16:04:15 2021 -0400

    add blubber cmd examples

commit cfc9d6ebc1d291e40867c13f8917731aef03169e
Author: nikkhn <nnikkhoui@gmail.com>
Date:   Tue Apr 27 22:40:24 2021 -0400

    typo fix, remove deprecated version num

commit ead8dc65444465bc419e29fb1ac059810933dcec
Author: nikkhn <nnikkhoui@gmail.com>
Date:   Tue Apr 27 16:36:00 2021 -0400

    Add blurb about blubber and docker script deprecation

commit 31564778bdb11cedec4c332dcfd1a2a4c86fc693
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Thu Mar 25 08:31:50 2021 -0600

    Release 0.10.0

commit 8711466566fdbfd31547c98670a13f166461c747
Author: Cole White <cwhite@wikimedia.org>
Date:   Mon Mar 30 18:02:21 2020 -0600

    Update router metric to Histogram.
    Use toggleable service label for router metric.

    Bug: T238658
    Bug: T247820

commit 1ddc445b50b91815765672129f6fe379f981978d
Author: Cole White <cwhite@wikimedia.org>
Date:   Mon Nov 18 16:58:11 2019 -0700

    update service-template-node to use service-runner branch with new metrics api

commit 5cf79c8f1bfab8827b465cd32e6b391505883632
Merge: e13b30f 8e7192f
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Mon Feb 22 16:45:42 2021 -0600

    Merge pull request #146 from nikkhn/use-chai

    Use chai assertions

commit 8e7192f28b89dd802d0dcf786816ecaf1fec029e
Author: nikkhn <nnikkhoui@gmail.com>
Date:   Thu Feb 18 12:08:04 2021 -1000

    add test for assert.fails()

commit 1480c164ab157d126aa9d9d65ac84e76e8e0c17d
Author: nikkhn <nnikkhoui@gmail.com>
Date:   Thu Feb 18 11:46:56 2021 -1000

    bump minor version

commit e17bd8eb34150d0a94e709a7fabec133bc087fcc
Author: nikkhn <nnikkhoui@gmail.com>
Date:   Thu Feb 18 11:35:41 2021 -1000

    export assertions through chai

commit a07af81f05528809fcf90bbe72d5a9879c1f7a62
Author: nikkhn <nnikkhoui@gmail.com>
Date:   Wed Feb 17 22:13:04 2021 -1000

    add chai to package.json

commit 75740c9863a99328c60a0016d5bb771b3769719b
Author: nikkhn <nnikkhoui@gmail.com>
Date:   Wed Feb 17 22:12:02 2021 -1000

    Use chai assertion library

commit e13b30fe6898b55d913074e79b398f0402ef8008
Merge: b72e0db 3259797
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Mon Feb 8 13:15:26 2021 -0600

    Merge pull request #145 from nikkhn/remove-deploy-config

    Remove targets.yaml and deploy stanza

commit 325979780be9c8c58b100ba7befdff1e681623eb
Author: Nikki Nikkhoui <nnikkhoui@wikimedia.org>
Date:   Fri Feb 5 14:33:59 2021 -1000

    Remove targets.yaml and deploy config

commit c4c92be345a83c29c7809c2b01c0f3b2a12c5b46
Merge: 55c88e3 6eea78c
Author: Clara Andrew-Wani <candrewwani@gmail.com>
Date:   Fri Nov 20 11:15:03 2020 -0500

    Merge remote-tracking branch 'upstream/prometheus_metrics'

    # Conflicts:
    #	package.json

commit 55c88e3209ebe532a7733c88541ebb7e0ec8ac85
Author: Clara Andrew-Wani <candrewwani@gmail.com>
Date:   Thu Nov 19 11:45:55 2020 -0500

    Update service-runner to v2.8.0

commit b72e0dbaba9c9f3be04af597edb2c914e807dfb3
Merge: 83115c5 06288be
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Thu Nov 19 06:52:57 2020 -0700

    Merge pull request #141 from wikimedia/sbasset

    Harden default CSP settings within app.js

commit 06288becdc7c64071f1ee984d89aaa2742f3969b
Author: sbassett <sbassett@wikimedia.org>
Date:   Fri Sep 11 13:54:23 2020 -0500

    Harden default CSP settings within app.js

    The Service-Template-Node code is used for many internal
    wikimedia services where security headers are likely unnecessary.
    Still, if defaults are to be provided, those should be as secure
    and up-to-date as possible.  Especially if any service were to
    ever be made public in any way or an attacker found some novel
    way of exploiting various services lacking sufficient protection
    via security headers.  This pull request:

    * Hardens default CSP policy, namely adding values of 'none' for
    various sources and specifying the base-uri directive.

    * Removes the deprecated x-webkit-csp and x-content-security-policy
    headers.

    Note: per developer.mozilla.org docs, x-frame-options is
    obsolete if a frame-ancestors directive is specified within the
    CSP.  x-xss-protection is also obsolete with a CSP that disallows
    unsafe-inline scripts.  Both of these are satisfied by STN and
    can be removed.  access-control-allow-origin should likely not
    default to '*', but I don't have a good suggestion of an
    appropriate default value that wouldn't potentially break
    things somewhat unnecessarily.

    Bug: T262652

commit 83115c586da58811160cfdd7655605edc8c8d6d7
Merge: 7989407 d655509
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Thu Nov 19 06:01:39 2020 -0700

    Merge pull request #132 from wikimedia/hyg-0

    Remove init scripts

commit 79894076d82742b807173a8c4c3005e082991dc8
Merge: 240c9df 3b65e54
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Thu Nov 19 06:01:15 2020 -0700

    Merge pull request #140 from wikimedia/updatelint

    Update linting packages and release version 0.8.0

commit 3b65e542051c054abae8d2525dbd3230d14ec5aa
Author: Marielle Volz <marielle.volz@gmail.com>
Date:   Wed Nov 11 10:59:32 2020 +0000

    Update minor version and target node 10

commit e4c71d7b35d9faaa8e32bd3ae6d6dc044cb1c81e
Author: Marielle Volz <marielle.volz@gmail.com>
Date:   Wed Nov 11 10:41:54 2020 +0000

    Remove testing against node 6, test against dev

    We no longer support 6 in production, so
    remove support travis builds for it.

    Also re-add in node (dev version)  which was
    previously removed in 22758bdad8d0, as it's
    good to test against future versions of node.

commit 28dafed082d129b80c4d910a95891a9f2a109f67
Author: Marielle Volz <marielle.volz@gmail.com>
Date:   Tue Nov 10 14:36:23 2020 +0000

    Alphabetise eslintrc rules

    These were only partially alphabetised. This
    makes it easier to compare rules with
    other repositories using the template.

commit a7cddb834c4db415486d7ce35fe80f80cd36757f
Author: Marielle Volz <marielle.volz@gmail.com>
Date:   Tue Nov 10 14:27:20 2020 +0000

    Remove rules now included upstream

    Remove extends rules which are now
    included upstream in wikimedia/server,
    as well as individual rule also
    included (prefer const now errors
    by default.)

commit 867ebe6e8982ad9275cab81587baec46a105b14b
Author: Marielle Volz <marielle.volz@gmail.com>
Date:   Tue Nov 10 10:58:59 2020 +0000

    Update eslint packages with new rules

    New rules were added as the result of this update
    	*no shadow: temporarily turned off for this change
            *jsdoc/no undefined types: turned off
            *jsdoc/newline-after-description: automatically fixed
    using fix script.

    Remove max-len override in app.js as not emitting warning

commit 240c9df76bacfd604ab3239e289a50784ae683d0
Author: Bernd Sitzmann <bsitzmann@wikimedia.org>
Date:   Mon May 4 14:11:26 2020 -0600

    eslint: Add fix script

    Change-Id: I179aa8369ed6ccf67f7c045caf904d42fd41eccb

commit 884ebba73724339cafccec4e9f38cd10251f1ed4
Author: Bernd Sitzmann <bsitzmann@wikimedia.org>
Date:   Mon May 4 13:10:02 2020 -0600

    eslint: Extend node and es2016 rules

    Change-Id: I9f1fae362ee1ca551fd2f5f1876a7617f9e14a39

commit cb327ffbdcde36c569e7e3ce8452146e1c3ca346
Author: Bernd Sitzmann <bsitzmann@wikimedia.org>
Date:   Mon May 4 12:30:23 2020 -0600

    eslint: Move eslintrc file to json

    Better support in code editors.
    Autocompletion and tooltips in VSCode.

    Also github.com/wikimedia/eslint-config-wikimedia
    and examples on eslint.org use json.

    Change-Id: Ibcdf82d9cb94d416804d8da549ac0d51dafc058b

commit 6eea78cd6bca3baf9c46e26275bcc847a83268a2
Merge: 5b2a56a 6c1e6c0
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Mon Aug 10 15:54:48 2020 -0700

    Merge pull request #131 from shdubsh/T238658

    Use Histogram and use selective service label.

commit d655509585c9792062ffdaa42df70a806b0a0e6a
Author: Bernd Sitzmann <bsitzmann@wikimedia.org>
Date:   Mon May 4 11:22:58 2020 -0600

    Remove init scripts

    AFAIK they are not used.

commit 6c1e6c087971e789e82532d013b750d1cae05fb1
Author: Cole White <cwhite@wikimedia.org>
Date:   Mon Mar 30 18:02:21 2020 -0600

    Update router metric to Histogram.
    Use toggleable service label for router metric.

    Bug: T238658
    Bug: T247820

commit 69a09dd2b463786a1f86c4c80cf2d6d7054e4b4b
Merge: e02ff43 1df37f5
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Tue Mar 17 15:21:16 2020 +0400

    Merge pull request #130 from wikimedia/buster-node10

    blubber: Migrate from stretch/node6 to buster/node10

commit e02ff43c9224b53fbce7b7fa8b3a4aea31e35def
Merge: 4ab78be d39672b
Author: James Forrester <jforrester@wikimedia.org>
Date:   Mon Mar 16 20:47:24 2020 -0700

    Merge pull request #129 from wikimedia/configs

    Move comment about mw_api template closer to the template

commit 1df37f5ceccb958a5a6fb7544ddd097b44302f68
Author: James D. Forrester <jforrester@wikimedia.org>
Date:   Mon Mar 16 20:32:58 2020 -0700

    blubber: Migrate from stretch/node6 to buster/node10

commit d39672bdf97c1e4cc43b7dff0aa4226c921f7e1e
Author: Bernd Sitzmann <bsitzmann@wikimedia.org>
Date:   Mon Mar 16 14:44:40 2020 -0600

    Move comment about mw_api template closer to the template

    Also reformatted the comment about max_body_size to match other comments
    for consistency sake.

commit 5b2a56a0c856202294a5117f15dd222106485696
Merge: 4ab78be 3ee6345
Author: Andrew Otto <otto@wikimedia.org>
Date:   Wed Jan 15 10:56:37 2020 -0500

    Merge pull request #127 from shdubsh/T205870

    update service-runner dependency to 2.8.0 and implement new metrics API

commit 3ee6345f4e6f6c865e5666e7d4bbe6f567c4133c
Author: Cole White <cwhite@wikimedia.org>
Date:   Mon Nov 18 16:58:11 2019 -0700

    update service-template-node to use service-runner branch with new metrics api

commit 4ab78be1fb67b1178bcf295037fccc4451137738
Merge: 5a2dc3f db0833b
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Thu Jul 25 07:21:57 2019 -0700

    Merge pull request #126 from mdholloway/blubber-v4

    Bump Blubber to v4

commit db0833ba7c94acca4384c087e42adf814ea591c7
Author: Michael Holloway <mholloway@wikimedia.org>
Date:   Thu Jul 25 10:15:44 2019 -0400

    Bump Blubber to v4

    Note the updated "copies" behavior as reflected in recent changes to the
    Blubber user guide.

    https://wikitech.wikimedia.org/w/index.php?title=Blubber%2FUser_Guide&type=revision&diff=1833502&oldid=1833501

commit 5a2dc3f156b64dd43b9969d6e5bf71708c6705d0
Merge: a92ccce 7d9f38f
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Wed Jul 10 17:13:48 2019 -0400

    Merge pull request #116 from hknustwmf/master

    T219427 - Replaced custom test server with ServiceRunner test server

commit a92cccea9df8af7bda315b4eb41495c95bbfbdad
Author: Marko Obrovac <marko.obrovac@gmail.com>
Date:   Thu Jun 13 13:15:56 2019 +0200

    Propagate the request ID when issuing requests; rel v0.7.0

    This commit changes the API of the Request object and the utility
    functions used to contact the MW and REST APIs. The Request object now
    has a `context` property that includes the request ID. Additionally, the
    request now features an `issueRequest()` method which should be used
    instead of `preq`. It augments the request by setting the user-agent and
    x-request-id headers automatically, in this way propagating the request
    ID further down the call chain.

    In order to account for these changes, `mwApiGet()` and `restApiGet()`
    have been changed to take the request as a parameter instead of the
    application object.

    Bug: T225711

commit b3b59baff9354b5701ba48b7c124106153fbb405
Author: Andrew Otto <acotto@gmail.com>
Date:   Tue Jun 18 11:46:27 2019 -0400

    Allow configuration of bodyParser limit via app.conf.max_body_size

    Bug: T226026

commit 7d9f38fbbaca867b199a30f20496bf50e7aceeb3
Author: Holger Knust <hknust@wikimedia.org>
Date:   Mon May 27 19:58:21 2019 -0400

    Replaced custom test server with ServiceRunner test server and adjusted the tests where necessary

    Bug: T219427

commit 6d195e3624cb08d91bf70cbe98b83c0b15c95096
Author: Marko Obrovac <marko.obrovac@gmail.com>
Date:   Sat Jun 8 11:43:56 2019 +0200

    HTTPError: Favour err.detail over err.message if present

    When an error provides the `detail` field, favour displaying it over
    `message` as it oftentimes provides more useful info.

    Bug: T225329

commit 4a51f880df60cd060acad972b1afef23bdb8b745
Author: Michael Holloway <mholloway@wikimedia.org>
Date:   Thu Jun 6 13:35:45 2019 -0400

    Add Blubber config

    Adds a basic Blubber config that successfully builds all existing
    dependnencies.

    This is in support of new services being built for the k8s pipeline.

    Phab: https://phabricator.wikimedia.org/T225228

commit f99627af57564b1906c85d4d44c17fb8345c8db3
Author: Marko Obrovac <marko.obrovac@gmail.com>
Date:   Mon Jun 10 20:06:59 2019 +0200

    Bump dependencies, ignore packge-lock.json

commit e05916550df292258c8637ee90c2dad17e065312
Merge: 2a95174 b612d42
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Mon Jun 10 09:28:13 2019 +0300

    Merge pull request #121 from hknustwmf/T223690

    Replaced Cassandra-uuid with uuid

commit b612d4286699935c2b187c4bef5db52b254e4472
Author: Holger Knust <hknust@wikimedia.org>
Date:   Thu Jun 6 16:24:26 2019 -0400

    Replaced Cassandra-uuid with uuid

    Bug: T223690

commit 2a9517491b7a03968f691cf6cedd120e7abbea14
Merge: c29fd5f 0bb5f1a
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Thu Jun 6 10:09:41 2019 +0300

    Merge pull request #118 from hknustwmf/T216191

    T216191 Replace Istanbul with nyc

commit 0bb5f1a110c1eac83d4d6b48af0fc3ab4e6848d9
Author: Holger Knust <hknust@wikimedia.org>
Date:   Wed Jun 5 14:43:11 2019 -0400

    Replaced Istanbul with nyc package

    Bug: T216191

commit c29fd5f51a73fb0e38db906afb7437185203d9d1
Author: Petr Pchelko <ppchelko@wikimedia.org>
Date:   Wed Jun 5 11:04:37 2019 +0300

    Provide proper CSP headers for docs and add validation test

commit 9c266703f8daf0945ec7c70ec45b706517c7a47f
Merge: 2a449f7 22758bd
Author: Petr Pchelko <petrpchelko@gmail.com>
Date:   Wed Jun 5 10:52:42 2019 +0300

    Merge pull request #115 from mateusbs17/master

    Use swagger-ui-dist instead of swagger-ui

commit 22758bdad8d0c8909837c498ed123598286dfa90
Author: Mateus Santos <msantos@wikimedia.org>
Date:   Mon Apr 29 16:08:54 2019 -0300

    Hygiene and remove swagger 2 support

    1) Removing 'node' from travis.yml, support node 10 instead of node 8
    2) Support only openapi 3 spec
    3) Update spec.example.yaml to be openapi 3 compliant
    4) Bump minor version

commit 43031b64534f2513083641a3ddc3a85fca44175f
Author: Mateus Santos <msantos@wikimedia.org>
Date:   Mon Apr 29 15:51:56 2019 -0300

    Use swagger-ui-dist instead of swagger-ui

    Based on hyperswitch implementation. See
    wikimedia/hyperswitch@a040a59

    Bug: T218217

commit 2a449f7e27ed2e23e182d3ecbf11fd300e9390e1
Merge: 6a97b65 c022544
Author: Alexandros Kosiaris <akosiaris@gmail.com>
Date:   Wed Feb 27 00:34:41 2019 +0200

    Merge pull request #114 from akosiaris/master

    Partially revert "Fixed Proper /robots.txt handling"

commit c022544c9094df7b72a6c78e2dc8e4456df826bd
Author: Alexandros Kosiaris <akosiaris@gmail.com>
Date:   Wed Feb 27 00:20:19 2019 +0200

    Revert "Fixed Proper /robots.txt handling"

    This partially reverts commit 67d02b6.
    The original "standard" says robots.txt is what essentially amounts to a
    text/plain file one or more records separated by blanklines, with every
    record containing lines of the form "<field>: <value>" essentially

    The original standard can be found at http://www.robotstxt.org/orig.html

commit 6a97b65270127386034fd6739f207140520ec2f6
Author: Holger Knust <hknust@wikimedia.org>
Date:   Tue Jan 22 19:20:01 2019 -0500

    Fixed issue with test timeout var definition in package.json and anonymous function def in util.js with arrow function.

commit 25e14b99d863672dc81a4ec5a719adaea28fb625
Author: Holger Knust <hknust@wikimedia.org>
Date:   Tue Jan 22 18:18:19 2019 -0500

    Added coverage folder to .eslintignore

commit 49788967277def364b25c006fe787149e38bb4df
Author: Holger Knust <hknust@wikimedia.org>
Date:   Tue Jan 22 15:27:36 2019 -0500

    Use arrow function for export in app.js

commit 097d9b2b7b0e486e367689db84d4ef6c22f983fb
Author: Holger Knust <hknust@wikimedia.org>
Date:   Tue Jan 22 12:25:26 2019 -0500

    Bumped version from 0.5.8 to 0.5.9

commit c468defdd0b7f460c244d64381e70411bed94f88
Author: Holger Knust <hknust@wikimedia.org>
Date:   Tue Jan 22 12:19:35 2019 -0500

    Removed max-len eslint exceptions for most default settings

commit 20f7c867fb25f8ad4f33adef13d2369a9f65ce3c
Author: Holger Knust <hknust@wikimedia.org>
Date:   Tue Jan 22 11:59:01 2019 -0500

    Turned on plugins

commit 07acb8ac15cac27ae5a8ecbb9141ba20b6883140
Author: Holger Knust <hknust@wikimedia.org>
Date:   Tue Jan 22 11:48:28 2019 -0500

    Remove eslint-config-node-services and updated eslint-config-wikimedia to latest. Minor style changes in code to accommodate  common styleguides.

commit 5b161329f0a4d13546581a6f889b20d9991073c1
Merge: 674ae86 7c6d284
Author: Petr Pchelko <petrpchelko@gmail.com>
Date:   Mon Dec 10 12:16:09 2018 -0800

    Merge pull request #112 from mdholloway/bye-nsp

    Hygiene: Retire the nsp module

commit 7c6d2847509bd0f8fae17cc87afd6f7af44b555d
Author: Michael Holloway <mholloway@wikimedia.org>
Date:   Mon Dec 10 14:12:49 2018 -0600

    Hygiene: Retire the nsp module

    The nodesecurity.io domain has been decommissioned, and nsp is now
    returning errors:

     (+) Client request error: getaddrinfo ENOTFOUND api.nodesecurity.io api.nodesecurity.io:443

    Time to move on to `npm audit`.

commit 674ae8654606ecb7faeb7aade448f0f6fedd7636
Merge: 16eae68 853a172
Author: Petr Pchelko <petrpchelko@gmail.com>
Date:   Tue Nov 27 12:17:50 2018 -0500

    Merge pull request #110 from mdholloway/eslint

    Eliminate the mocha-eslint dependency

commit 853a172990bf18a3ffb009c214de6d6aa1724edd
Author: Michael Holloway <mholloway@wikimedia.org>
Date:   Tue Nov 27 11:15:29 2018 -0600

    0.5.8

commit 624af9ac15c01181c76581c63f1c8af2385df507
Author: Michael Holloway <mholloway@wikimedia.org>
Date:   Mon Nov 26 19:17:06 2018 -0600

    Eliminate the mocha-eslint dependency

    The mocha-eslint package appears abandoned.  It pulls in an older version
    of eslint (^4.2.0, currently resolving to 4.19.1) than is required by
    eslint-config-wikimedia (^5.9.0).  This is true even for the current mocha-
    eslint version.

    This patch bumps the requested eslint version to ^5.9.0 and drops the
    mocha-eslint dependency in favor of a direct eslint invocation in the npm
    test script. One minor spacing change was needed to comply with the update.

    Upstreams the related mobileapps change:
    https://gerrit.wikimedia.org/r/#/c/mediawiki/services/mobileapps/+/475832/

    Bug: https://phabricator.wikimedia.org/T210460

commit 16eae68e78f37f7885eb6e507c5d14e75e61c97f
Merge: 1784fd1 0fb04ce
Author: Petr Pchelko <petrpchelko@gmail.com>
Date:   Wed Oct 31 11:35:09 2018 -0500

    Merge pull request #109 from clarakosi/update-dependencies

    updated dependencies

commit 0fb04ce67e73e5f7cad7da6d6de838165ff235b2
Author: clarakosi <candrewwani@gmail.com>
Date:   Wed Oct 31 12:21:48 2018 -0400

    updated dependencies

    Updated dependencies and bumped patch number to 0.5.7
@ottomata
Copy link
Contributor Author

ottomata commented Oct 5, 2023

I think I'm going to get rid of node-rdkafka-factory and just bring that code into this codebase. It isn't used anywhere else, and will remove one extra dependency to manage...

@ottomata ottomata force-pushed the T347477_upgrade_node branch 2 times, most recently from fe6facf to 7136024 Compare October 5, 2023 20:40
Previous commit updates to latest service-template-node.

- Lint fixes
- Update some dependencies.
- Copy @wikimedia/node-rdkafka-factory code to lib/kafka.js.
  This extra dependency can be eliminated.

Bug: T347477
@ottomata ottomata force-pushed the T347477_upgrade_node branch from 7136024 to abec225 Compare October 5, 2023 20:46
@ottomata ottomata merged commit aee1c2c into wikimedia:master Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant