Redesign of navigation and headers of pages#145
Merged
Conversation
MusikAnimal
force-pushed
the
redesign-T206495
branch
2 times, most recently
from
90e916d to
890a60d
Compare
Member
Author
|
Note to reviewers: All those i18n changes were removals of now-obsolete messages, and importing translations for "settings" and "save" from another application (where they are used in an identical fashion). So basically you can just review en.json and qqq.json :) |
MusikAnimal
force-pushed
the
redesign-T206495
branch
from
890a60d to
12202b3
Compare
MusikAnimal
force-pushed
the
redesign-T206495
branch
from
12202b3 to
20f419c
Compare
MusikAnimal
force-pushed
the
redesign-T206495
branch
from
20f419c to
53f35cd
Compare
Member
|
This looks good to me overall. A couple of notes:
Not a blocker for this PR, but could be good to do for next time. I'm waiting to merge this for the fix of the first bullet point --- otherwise, seems good to be merged. |
Member
|
Things seem to be fixed; whatever followup can be done in a followup PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: https://phabricator.wikimedia.org/T206495