Skip to content

Clean up the position function and move the menu into the screen if it goes away#272

Merged
kartikm merged 3 commits intowikimedia:masterfrom
amire80:bug-52154
Sep 9, 2013
Merged

Clean up the position function and move the menu into the screen if it goes away#272
kartikm merged 3 commits intowikimedia:masterfrom
amire80:bug-52154

Conversation

@amire80
Copy link
Collaborator

@amire80 amire80 commented Sep 6, 2013

This is supposed to fix this downstream bug:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52154

@kartikm
Copy link
Member

kartikm commented Sep 6, 2013

Errors during running tests/

Am I missing something or rtlElement is really not defined? :)

  1. Setup failed on Initialization tests: rtlElement is not defined
    Source:
    at IMESelector.position (http://localhost:8000/src/jquery.ime.selector.js:321:10)
    at IMESelector.init (http://localhost:8000/src/jquery.ime.selector.js:23:9)
    at new IMESelector (http://localhost:8000/src/jquery.ime.selector.js:14:8)
    at HTMLTextAreaElement. (http://localhost:8000/src/jquery.ime.selector.js:587:41)
    at Function.x.extend.each (https://ajax.googleapis.com/ajax/libs/jquery/1.10.1/jquery.min.js:4:5347)
    at x.fn.x.each (https://ajax.googleapis.com/ajax/libs/jquery/1.10.1/jquery.min.js:4:1999)
    at $.fn.imeselector (http://localhost:8000/src/jquery.ime.selector.js:582:15)
    at new IME (http://localhost:8000/src/jquery.ime.js:22:33)
    at HTMLTextAreaElement. (http://localhost:8000/src/jquery.ime.js:361:12)
    at Function.x.extend.each (https://ajax.googleapis.com/ajax/libs/jquery/1.10.1/jquery.min.js:4:5347)
  2. Died on test Fix for the lack of border of the callout triangle. #4 at http://localhost:8000/test/jquery.ime.test.js:17:8
    at http://localhost:8000/test/jquery.ime.test.js:438:2: rtlElement is not defined
    Source:
    ReferenceError: rtlElement is not defined
    at IMESelector.position (http://localhost:8000/src/jquery.ime.selector.js:321:10)
    at IMESelector.init (http://localhost:8000/src/jquery.ime.selector.js:23:9)
    at new IMESelector (http://localhost:8000/src/jquery.ime.selector.js:14:8)
    at HTMLInputElement. (http://localhost:8000/src/jquery.ime.selector.js:587:41)
    at Function.x.extend.each (https://ajax.googleapis.com/ajax/libs/jquery/1.10.1/jquery.min.js:4:5347)
    at x.fn.x.each (https://ajax.googleapis.com/ajax/libs/jquery/1.10.1/jquery.min.js:4:1999)
    at $.fn.imeselector (http://localhost:8000/src/jquery.ime.selector.js:582:15)
    at new IME (http://localhost:8000/src/jquery.ime.js:22:33)
    at HTMLInputElement. (http://localhost:8000/src/jquery.ime.js:361:12)
    at Function.x.extend.each (https://ajax.googleapis.com/ajax/libs/jquery/1.10.1/jquery.min.js:4:5347)

Summary:

Tests completed in 52898 milliseconds.
173 tests of 747 passed, 574 failed.

Unbreaks the previous commit.
kartikm added a commit that referenced this pull request Sep 9, 2013
Clean up the position function and move the menu into the screen if it goes away
@kartikm kartikm merged commit 2d5836e into wikimedia:master Sep 9, 2013
@amire80 amire80 deleted the bug-52154 branch July 18, 2015 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants