[#450] Replace urdu numerals to use standard numerals#451
Merged
kartikm merged 1 commit intowikimedia:masterfrom Aug 14, 2016
Merged
[#450] Replace urdu numerals to use standard numerals#451kartikm merged 1 commit intowikimedia:masterfrom
kartikm merged 1 commit intowikimedia:masterfrom
Conversation
Member
|
Patch looks good to me. It would be nice if you add 2 or 3 tests at, test/jquery.ime.test.fixtures.js Look at similar tests from other languages. |
rules/ur/ur-phonetic.js
Outdated
| [ '!', '!' ], | ||
| [ '1', '۱' ], | ||
| [ '2', '۲' ], | ||
| [ '1', '1' ], |
Member
There was a problem hiding this comment.
You can just remove the mapping for the numeral. [ '1', '1' ] has no effect(it means when you type 1, produce 1, which anyway is the default behavior
Contributor
Author
There was a problem hiding this comment.
Thats right. Dont know why I did that in the first place. Removing now
tonythomas01
force-pushed
the
normal-numerals
branch
from
4b139d8 to
214616a
Compare
tonythomas01
force-pushed
the
normal-numerals
branch
from
214616a to
425ece2
Compare
Contributor
Author
|
I have pushed in a test too, which I am ashamed to admit that I couldn't test personally :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convention on urwiki is to use Latin numerals, which is not possible with their favoured (phonetic) IME.
https://github.com/wikimedia/jquery.ime/blob/HEAD/rules/ur/ur-phonetic.js is the definition with
[ '1', '۱' ]rather than[ '1', '1' ](Reported in person by @hindustanilanguage.) in https://phabricator.wikimedia.org/T138399