Allow limiting languages in getLanguagesByScriptGroupInRegion and add a test#20
Closed
amire80 wants to merge 4 commits intowikimedia:masterfrom
Closed
Allow limiting languages in getLanguagesByScriptGroupInRegion and add a test#20amire80 wants to merge 4 commits intowikimedia:masterfrom
amire80 wants to merge 4 commits intowikimedia:masterfrom
Conversation
… a test This is a step towards resolving downstream bug https://phabricator.wikimedia.org/T189090 The next step is to add a function that uses getLanguagesByScriptGroupInRegion and orders the languages by autonym.
Member
|
This looks unnecessarily complicated. Just sort by autonym first and then pass the codes to the function that returns them by script groups (assuming it keeps the order stable)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a step towards resolving downstream bug
https://phabricator.wikimedia.org/T189090
The next step is to add a function that uses getLanguagesByScriptGroupInRegion
and orders the languages by autonym.