Skip to content

Media: Remove revision parameter #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mdholloway wants to merge 1 commit into from
Closed

Media: Remove revision parameter #1021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions v1/media.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ info:
name: Apache licence, v2
url: https://www.apache.org/licenses/LICENSE-2.0
paths:
/media/{title}{/revision}:
/media/{title}:
x-route-filters:
- path: ./lib/revision_table_access_check_filter.js
options:
Expand All @@ -34,12 +34,6 @@ paths:
description: "Page title. Use underscores instead of spaces. Example: `Main_Page`."
type: string
required: true
- name: revision
in: path
description: >
Optional page revision. Note that older revisions are not stored, so
request latency with the revision would be higher.
required: false
- name: redirect
in: query
description: >
Expand Down Expand Up @@ -89,7 +83,7 @@ paths:
method: get
headers:
cache-control: '{{cache-control}}'
uri: '{{options.host}}/{domain}/v1/page/media/{title}/{revision}'
uri: '{{options.host}}/{domain}/v1/page/media/{title}'
return:
status: 200
headers: '{{ merge({"cache-control": options.response_cache_control},
Expand All @@ -102,7 +96,6 @@ paths:
params:
domain: en.wikipedia.org
title: User:BSitzmann_(WMF)/MCS/Test/Frankenstein
revision: 803891963
response:
status: 200
headers:
Expand Down