Use parsoid-external-ci-access.beta.wmflabs.org for testing#1245
Use parsoid-external-ci-access.beta.wmflabs.org for testing#1245cscott wants to merge 3 commits intowikimedia:masterfrom
Conversation
|
Two failing tests: It seems to be the redirect which is causing problems, since the redirect goes to: Second failure is 'router - security > should forward cookies on request to parsoid'. |
Bug: T247589 Change-Id: I30de94cf4c4e0b03fcccae534290e0f4ca0ef751
When the parsoid_uri is not the same as the site config domain, the "native" redirect handling for page lints will send restbase to the wrong place. Change-Id: I4da0a4213332af7dec850b94f7f8fad65745aa1f
|
Ok, this should fix the tests. It's possible the issue with There are some transient failures which seem to be caused by github parallelizing the tests which create and mutate https://en.wikipedia.beta.wmflabs.org/wiki/Save_test |
|
The "prevent concurrent execution" thing doesn't actually seem to work. The page name should include |
…low matrix We were getting spurious errors in the tests which test the save API, all of which were writing to https://en.wikipedia.beta.wmflabs.org/wiki/Save_test in parallel. Change-Id: I863750730c26674882c21b391499fa2bcdeb9258
|
OK, this is good now. |
|
Hm.. thank you for setting up the parsoid-ci-access, however with the test fixes - I'm not sure they're correct. For example the page_save test that you're setting the page via an env variable now is actually completely mocked and should be not calling real services (we were getting complaints for creating gazillion pages on beta). I think I should just take it on from here and try to poke some other approaches to fixing those tests, there's probably just something hardcoded somewhere, |
Bug: T247589