Provide page id and revision timestamp in revision data end point

[JonCook]

Relating to changes described in:
https://phabricator.wikimedia.org/T95364

[coveralls]

Coverage increased (+0.01%) to 86.85% when pulling 967fa02 on JonCook:master into 607b6bc on wikimedia:master.

[coveralls]

Coverage increased (+0.01%) to 86.85% when pulling 967fa02 on JonCook:master into 607b6bc on wikimedia:master.

[gwicke]

@JonCook, thank you for your patch! This looks good to go to me. The only blocker is that we'll need schema migration support for existing content before we can merge / deploy this. @eevans is currently working on https://phabricator.wikimedia.org/T75808, and is looking into support for adding columns in particular.

[gwicke]

/cc @d00rman

[d00rman]

Can be simply:

var redirect = dataResp.redirect !== undefined;

[d00rman]

Looks really good @JonCook, thank you for contributing! As @gwicke mentioned, we need to implement and deploy schema migrations before we can deploy this change, so we are leaving it open until then. Minor nitpicks in-lined.

[JonCook]

Thanks for the comments. I'll fix the minor nitpicks later. The indentation is a bit strange as well as it looks ok in my text editor.

[d00rman]

The indentation is a bit strange as well as it looks ok in my text editor.

Might be a tabs vs spaces issue

[coveralls]

Coverage increased (+0.01%) to 86.85% when pulling 3df3fe1 on JonCook:master into 607b6bc on wikimedia:master.

[gwicke]

Might be a tabs vs spaces issue

Yeah, there are still some stray tabs in some of the test files. Lets clean that up in a separate patch.

[JonCook]

I updated the minor nitpicks. Hope it is ok. Think it is ready to go now when you've finished the schema migration changes.

[coveralls]

Coverage increased (+0.01%) to 86.85% when pulling f5a1e0b on JonCook:master into 607b6bc on wikimedia:master.

[gwicke]

@JonCook, the schema support has landed now, but we'll hold of with merging this until after the Monday deploy to reduce the amount of change we deploy at once.

[JonCook]

@gwicke Did the Monday deploy go ok? Is it safe for you guys to go ahead with this merge?

[gwicke]

@JonCook, the Monday deploy went well, and I just merged the capability to actually add columns. We'll be doing one more deploy tomorrow before likely pushing this out on Thursday.

[gwicke]

@JonCook, after some testing your code went live 15 minutes ago. It's all looking great, so thanks a lot for your contribution! The next step will now be to leverage this information in HTML dumps (https://phabricator.wikimedia.org/T93396 and https://github.com/wikimedia/htmldumper).

[JonCook]

Great, thanks. Glad I could help/contribute!