Paging#260
Merged
Merged
Conversation
- Move utility methods in restbase class to the end, so that they don't break up the flow of the main class. - Update jsonwebtoken dependency to 5.0.0, which has some important security fixes. - Use proper limit and paging parameters for cassandra backend. - Validate the config to assert that the `salt` parameter is set, and fail early during startup if it isn't.
- Query -> query in swagger spec - Remove stray console.log
Closed
Contributor
Author
|
LGTM as-is 👍 |
gwicke
added a commit
that referenced
this pull request
Jun 12, 2015
Contributor
Author
|
Corresponding configuration patch is here |
wmfgerrit
pushed a commit
to wikimedia/operations-puppet
that referenced
this pull request
Jun 15, 2015
As of wikimedia/restbase#260 RESTBase supports proper result paging, for which the salt and default_page_size configuration options need to be present. This patch adds the defaults for both production and deployment-prep. Note: salt_key should truly be a secret phrase, so this patch needs a corresponding key in the private repo setting it. Change-Id: I463922e4d27d3272c24575f99aac69bc2eebdcea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yet another paging PR :)
Note: need to add the
saltconfig directive to the production configuration before deployment