Skip to content

WIP: binary png support#547

Closed
physikerwelt wants to merge 1 commit into
wikimedia:masterfrom
physikerwelt:png
Closed

WIP: binary png support#547
physikerwelt wants to merge 1 commit into
wikimedia:masterfrom
physikerwelt:png

Conversation

@physikerwelt
Copy link
Copy Markdown
Member

needs more work as discussed with @d00rman

the problem is that the binary format is not understood by restbase it returns something like {"type":"Buffer","data":[137,80,78,71...
and is not interpreted as a png by the browser

@physikerwelt
Copy link
Copy Markdown
Member Author

I have no idea why the node 0.10 tests fail and the rest passes https://travis-ci.org/wikimedia/restbase/builds/115086087
This depends on https://gerrit.wikimedia.org/r/#/c/276495/

@Pchelolo
Copy link
Copy Markdown
Contributor

@physikerwelt 0.10 test fixed after restarting. Some intermittent cassandra issue

Comment thread v1/mathoid.yaml
enum:
- svg
- mml
- png
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add png to the list on line 109.

@d00rman d00rman added the API label Mar 11, 2016
wmfgerrit pushed a commit to wikimedia/mediawiki-services-mathoid that referenced this pull request Mar 11, 2016
* Get's the binary version of the PNG image
* Required for wikimedia/restbase#547

Change-Id: I8b71c0ee9bea99e1bc2a61923caa8c0bfb76d94c
@d00rman
Copy link
Copy Markdown
Contributor

d00rman commented Mar 12, 2016

Superseded by #552

@d00rman d00rman closed this Mar 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants