Added a table module to switch storage with config option#560
Merged
Conversation
| @@ -0,0 +1,13 @@ | |||
| "use strict"; | |||
Member
There was a problem hiding this comment.
A small comment explaining what this does would be useful.
Member
|
Nice! Might be nice to add a little comment, but otherwise this looks good to go to me. |
gwicke
added a commit
that referenced
this pull request
Mar 21, 2016
Added a table module to switch storage with config option
Contributor
Author
|
Created a patch for vagrant to use new config option: https://gerrit.wikimedia.org/r/278764 |
Contributor
|
This also needs a prod config change |
wmfgerrit
pushed a commit
to wikimedia/mediawiki-vagrant
that referenced
this pull request
Mar 22, 2016
After wikimedia/restbase#560 we're able to switch between cassandra and sqlite by a config option. This patch adds this option to vagrant, so we would be able to delete vagrant-specific configs from RESTBase codebase. Change-Id: I8a8fecaeed99fc1b3df55dd0fe9f534e29e2a66c
Contributor
Ah no, actually it doesn't strictly need it due to the set default. Nevertheless, it's good to have the complete config, so I put up https://gerrit.wikimedia.org/r/#/c/278893/ for today's PuppetSWAT. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a simple wrapper for storage modules that allows to select backend implementation with a config option. After this is landed, and vagrant is updated, we can remove the
wmf_sqlite.yamlandwikimedia.org.sqlite.yamlfiles. Also, we don't need to do the magic with temp files when running tests in sqlite mode.cc @wikimedia/services