Remove Varnish purging and release v0.14.0#621
Merged
Conversation
Contributor
Author
|
cc @wikimedia/services |
Contributor
Author
|
The prod config change is in Gerrit 290786 so this PR should be deployed together with it, even though that's not strictly needed as this PR is compatible with old configs too. |
|
Changes Unknown when pulling 90b5cd2 on d00rman:no-purges into * on wikimedia:master*. |
| host: 127.0.0.1 | ||
| port: 4321 | ||
| uri: http://127.0.0.1:8085/v1/events | ||
| topic: resource_change |
Contributor
There was a problem hiding this comment.
We didn't add the events config here before, because
- it's not strictly needed for testing
- not adding it verified that RB doesn't crash if the config is not there
- it makes tests slower a little bit since we make some additional requests
I don't have a strong opinion whether we should remove these 2 lines or leave them, up to you
Contributor
|
A couple of nits inline (I'm being really picky here, it's not important at all), otherwise 👍 |
We will start emitting Varnish purge requests from Change Prop, so remove the hacky cruft code for that from RESTBase.
Contributor
Author
|
Published as v0.14.0 |
wmfgerrit
pushed a commit
to wikimedia/operations-puppet
that referenced
this pull request
May 26, 2016
Once If9bd7e2907986be944bd351b27a000cbb12f2448 gets out, RESTBase will not need to issue Varnish purge requests, so clean up the config. Note that this needs to get out in tandem with wikimedia/restbase#621 and after If9bd7e2907986be944bd351b27a000cbb12f2448 . Change-Id: If50ef598bef64504016d57a56949751c855685fb Depends-On: If9bd7e2907986be944bd351b27a000cbb12f2448
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will start emitting Varnish purge requests from Change Prop, so remove the hacky cruft code for that from RESTBase.
Note: cannot be deployed before Gerrit 290748