Eliminate the mocha-eslint dependency#110
Merged
Merged
Conversation
The mocha-eslint package appears abandoned. It pulls in an older version of eslint (^4.2.0, currently resolving to 4.19.1) than is required by eslint-config-wikimedia (^5.9.0). This is true even for the current mocha- eslint version. This patch bumps the requested eslint version to ^5.9.0 and drops the mocha-eslint dependency in favor of a direct eslint invocation in the npm test script. One minor spacing change was needed to comply with the update. Upstreams the related mobileapps change: https://gerrit.wikimedia.org/r/#/c/mediawiki/services/mobileapps/+/475832/ Bug: https://phabricator.wikimedia.org/T210460
jdforrester
approved these changes
Nov 27, 2018
Contributor
|
Patch version bump and we're good to go |
Contributor
Author
|
bumped. |
Contributor
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mocha-eslint package appears abandoned. It pulls in an older version
of eslint (^4.2.0, currently resolving to 4.19.1) than is required by
eslint-config-wikimedia (^5.9.0). This is true even for the current mocha-
eslint version.
This patch bumps the requested eslint version to ^5.9.0 and drops the
mocha-eslint dependency in favor of a direct eslint invocation in the npm
test script. One minor spacing change was needed to comply with the update.
Upstreams the related mobileapps change:
https://gerrit.wikimedia.org/r/#/c/mediawiki/services/mobileapps/+/475832/
Bug: https://phabricator.wikimedia.org/T210460