Skip to content

Update dev variables and standardize endpoints to allow oauth access via frontend proxy#28

Merged
nbarnabee merged 5 commits intomainfrom
add_server_name_to_env
Feb 20, 2023
Merged

Update dev variables and standardize endpoints to allow oauth access via frontend proxy#28
nbarnabee merged 5 commits intomainfrom
add_server_name_to_env

Conversation

@nbarnabee
Copy link
Collaborator

Fixes the 404 errors that were introduced by the oauth patch.

Copy link
Collaborator

@Damilare1 Damilare1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, I added a supporting PR on the frontend to access the documentation when this is set to the container name. Here:

wikimedia/toolhunt-ui#28

This will allow them to work with the frontend proxy
@nbarnabee
Copy link
Collaborator Author

bab23d0 and 17470b5 address issues with the authorization routes. When used in conjunction with @Damilare1's PR, this allows access to the Oauth via the frontend site.

@nbarnabee nbarnabee changed the title Bugfix: Add server name to env.dev Update dev variables and standardize endpoints to allow oauth access via frontend proxy Feb 19, 2023
nbarnabee and others added 2 commits February 20, 2023 11:24
Updated instructions, as once this change is in place, attempts to
access the backend through localhost:5000 will fail.
@nbarnabee nbarnabee merged commit 1a4cefc into main Feb 20, 2023
@nbarnabee nbarnabee deleted the add_server_name_to_env branch February 20, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants